content/browser/service_worker/service_worker_context_request_handler.cc - Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler.cc

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_context_core.h ('K') | « content/browser/service_worker/service_worker_context_core.cc ('k') | content/browser/service_worker/service_worker_context_wrapper.h » ('j') | content/child/service_worker/service_worker_registration_handle_reference.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_context_request_handler.cc b/content/browser/service_worker/service_worker_context_request_handler.cc

index 867752162c373d591d87763817ec2e62387f86d9..67b8690feb12e5f0d7401e90504f27318f60e3dd 100644

--- a/content/browser/service_worker/service_worker_context_request_handler.cc

+++ b/content/browser/service_worker/service_worker_context_request_handler.cc

@@ -211,7 +211,7 @@ net::URLRequestJob* ServiceWorkerContextRequestHandler::MaybeCreateJobImpl(

base::Time::Now() - registration->last_update_check();

if (time_since_last_check >

base::TimeDelta::FromHours(kServiceWorkerScriptMaxCacheAgeInHours) ||

- version_->force_bypass_cache_for_scripts()) {

+ version_->force_bypass_cache_for_scripts() || registration->use_cache()) {

extra_load_flags = net::LOAD_BYPASS_CACHE;

}