Implement updateViaCache flag and no-cache by default for main service worker scripts

content/common/service_worker/service_worker_types.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/service_worker/service_worker_types.h"
 
 namespace content {
 
 const char kServiceWorkerRegisterErrorPrefix[] =
     "Failed to register a ServiceWorker: ";
@@ skipping 117 matching lines @@
 ServiceWorkerObjectInfo::ServiceWorkerObjectInfo()
     : handle_id(kInvalidServiceWorkerHandleId),
       state(blink::WebServiceWorkerStateUnknown),
       version_id(kInvalidServiceWorkerVersionId) {}
 
 bool ServiceWorkerObjectInfo::IsValid() const {
   return handle_id != kInvalidServiceWorkerHandleId &&
          version_id != kInvalidServiceWorkerVersionId;
 }
 
+ServiceWorkerRegistrationOptions::ServiceWorkerRegistrationOptions()
+    : use_cache(UseCache::DontUse) {}
+
+ServiceWorkerRegistrationOptions::ServiceWorkerRegistrationOptions(
+    const GURL& scope)
+    : scope(scope), use_cache(UseCache::DontUse) {}

[nhiroki, 2017/03/28 06:49:51]

Delegating constructor would work here:

ServiceWorkerRegistrationOptions::ServiceWorkerRegistrationOptions(
    const GURL& scope)
    : ServiceWorkerRegistrationOptions(scope, UseCache::DontUse) {}

[yuryu, 2017/07/20 10:15:12]

Done.

+
+ServiceWorkerRegistrationOptions::ServiceWorkerRegistrationOptions(
+    const GURL& scope,
+    UseCache use_cache)
+    : scope(scope), use_cache(use_cache) {}
+
 ServiceWorkerRegistrationObjectInfo::ServiceWorkerRegistrationObjectInfo()
     : handle_id(kInvalidServiceWorkerRegistrationHandleId),
-      registration_id(kInvalidServiceWorkerRegistrationId) {
-}
+      registration_id(kInvalidServiceWorkerRegistrationId) {}
 
 ServiceWorkerClientQueryOptions::ServiceWorkerClientQueryOptions()
     : client_type(blink::WebServiceWorkerClientTypeWindow),
       include_uncontrolled(false) {
 }
 
 ExtendableMessageEventSource::ExtendableMessageEventSource() {}
 
 ExtendableMessageEventSource::ExtendableMessageEventSource(
     const ServiceWorkerClientInfo& client_info)
     : client_info(client_info) {}
 
 ExtendableMessageEventSource::ExtendableMessageEventSource(
     const ServiceWorkerObjectInfo& service_worker_info)
     : service_worker_info(service_worker_info) {}
 
 NavigationPreloadState::NavigationPreloadState()
     : enabled(false), header("true") {}
 
 NavigationPreloadState::NavigationPreloadState(bool enabled, std::string header)
     : enabled(enabled), header(header) {}
 
 NavigationPreloadState::NavigationPreloadState(
     const NavigationPreloadState& other) = default;
 
 }  // namespace content