Implement updateViaCache flag and no-cache by default for main service worker scripts

content/browser/service_worker/link_header_support_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/link_header_support.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/run_loop.h"
 #include "content/browser/loader/resource_request_info_impl.h"
@@ skipping 93 matching lines @@
     std::unique_ptr<ServiceWorkerProviderHost> host =
         CreateProviderHostForServiceWorkerContext(
             render_process_id(), kMockProviderId,
             true /* is_parent_frame_secure */, context()->AsWeakPtr());
     provider_host_ = host->AsWeakPtr();
     EXPECT_FALSE(
         context()->GetProviderHost(host->process_id(), host->provider_id()));
     context()->AddProviderHost(std::move(host));
 
     scoped_refptr<ServiceWorkerRegistration> registration =
-        new ServiceWorkerRegistration(GURL("https://host/scope"), 1L,
+        new ServiceWorkerRegistration(GURL("https://host/scope"),
+                                      false /* use_cache* */, 1L,

[nhiroki, 2017/03/28 06:49:51]

There is an extra * ("use_cache*")

[yuryu, 2017/07/20 10:15:12]

Acknowledged.

                                       context()->AsWeakPtr());
     scoped_refptr<ServiceWorkerVersion> version = new ServiceWorkerVersion(
         registration.get(), GURL("https://host/script.js"), 1L,
         context()->AsWeakPtr());
 
     provider_host_->running_hosted_version_ = version;
   }
 
   std::unique_ptr<net::URLRequest> CreateRequest(const GURL& request_url,
                                                  ResourceType resource_type) {
@@ skipping 49 matching lines @@
   ProcessLinkHeaderForRequest(
       CreateSubresourceRequest(GURL("https://example.com/foo/bar/")).get(),
       "<../foo.js>; rel=serviceworker", context_wrapper());
   base::RunLoop().RunUntilIdle();
 
   std::vector<ServiceWorkerRegistrationInfo> registrations = GetRegistrations();
   ASSERT_EQ(1u, registrations.size());
   EXPECT_EQ(GURL("https://example.com/foo/"), registrations[0].pattern);
   EXPECT_EQ(GURL("https://example.com/foo/foo.js"),
             registrations[0].active_version.script_url);
+  EXPECT_FALSE(registrations[0].use_cache);
 }
 
 TEST_F(LinkHeaderServiceWorkerTest, InstallServiceWorker_ScopeWithFragment) {
   CreateDocumentProviderHost();
   ProcessLinkHeaderForRequest(
       CreateSubresourceRequest(GURL("https://example.com/foo/bar/")).get(),
       "<../bar.js>; rel=serviceworker; scope=\"scope#ref\"", context_wrapper());
   base::RunLoop().RunUntilIdle();
 
   std::vector<ServiceWorkerRegistrationInfo> registrations = GetRegistrations();
   ASSERT_EQ(1u, registrations.size());
   EXPECT_EQ(GURL("https://example.com/foo/bar/scope"),
             registrations[0].pattern);
   EXPECT_EQ(GURL("https://example.com/foo/bar.js"),
             registrations[0].active_version.script_url);
+  EXPECT_FALSE(registrations[0].use_cache);
 }
 
 TEST_F(LinkHeaderServiceWorkerTest, InstallServiceWorker_ScopeAbsoluteUrl) {
   CreateDocumentProviderHost();
   ProcessLinkHeaderForRequest(
       CreateSubresourceRequest(GURL("https://example.com/foo/bar/")).get(),
       "<bar.js>; rel=serviceworker; "
       "scope=\"https://example.com:443/foo/bar/scope\"",
       context_wrapper());
   base::RunLoop().RunUntilIdle();
 
   std::vector<ServiceWorkerRegistrationInfo> registrations = GetRegistrations();
   ASSERT_EQ(1u, registrations.size());
   EXPECT_EQ(GURL("https://example.com/foo/bar/scope"),
             registrations[0].pattern);
   EXPECT_EQ(GURL("https://example.com/foo/bar/bar.js"),
             registrations[0].active_version.script_url);
+  EXPECT_FALSE(registrations[0].use_cache);
 }
 
 TEST_F(LinkHeaderServiceWorkerTest, InstallServiceWorker_ScopeDifferentOrigin) {
   CreateDocumentProviderHost();
   ProcessLinkHeaderForRequest(
       CreateSubresourceRequest(GURL("https://example.com/foobar/")).get(),
       "<bar.js>; rel=serviceworker; scope=\"https://google.com/scope\"",
       context_wrapper());
   base::RunLoop().RunUntilIdle();
 
@@ skipping 30 matching lines @@
       CreateSubresourceRequest(GURL("https://example.com/foobar/")).get(),
       "<https://example.com/bar.js>; rel=serviceworker; scope=foo",
       context_wrapper());
   base::RunLoop().RunUntilIdle();
 
   std::vector<ServiceWorkerRegistrationInfo> registrations = GetRegistrations();
   ASSERT_EQ(1u, registrations.size());
   EXPECT_EQ(GURL("https://example.com/foobar/foo"), registrations[0].pattern);
   EXPECT_EQ(GURL("https://example.com/bar.js"),
             registrations[0].active_version.script_url);
+  EXPECT_FALSE(registrations[0].use_cache);
 }
 
 TEST_F(LinkHeaderServiceWorkerTest,
        InstallServiceWorker_ScriptDifferentOrigin) {
   CreateDocumentProviderHost();
   ProcessLinkHeaderForRequest(
       CreateSubresourceRequest(GURL("https://example.com/foobar/")).get(),
       "<https://google.com/bar.js>; rel=serviceworker; scope=foo",
       context_wrapper());
   base::RunLoop().RunUntilIdle();
 
   std::vector<ServiceWorkerRegistrationInfo> registrations = GetRegistrations();
   ASSERT_EQ(0u, registrations.size());
 }
 
+TEST_F(LinkHeaderServiceWorkerTest, InstallServiceWorker_UseCache) {
+  CreateDocumentProviderHost();
+  ProcessLinkHeaderForRequest(
+      CreateSubresourceRequest(GURL("https://example.com/foo/bar/")).get(),
+      "<../foo.js>; rel=serviceworker; usecache", context_wrapper());
+  base::RunLoop().RunUntilIdle();
+
+  std::vector<ServiceWorkerRegistrationInfo> registrations = GetRegistrations();
+  ASSERT_EQ(1u, registrations.size());
+  EXPECT_EQ(GURL("https://example.com/foo/"), registrations[0].pattern);
+  EXPECT_EQ(GURL("https://example.com/foo/foo.js"),
+            registrations[0].active_version.script_url);
+  EXPECT_TRUE(registrations[0].use_cache);
+}
+
 TEST_F(LinkHeaderServiceWorkerTest, InstallServiceWorker_MultipleWorkers) {
   CreateDocumentProviderHost();
   ProcessLinkHeaderForRequest(
       CreateSubresourceRequest(GURL("https://example.com/foobar/")).get(),
       "<bar.js>; rel=serviceworker; scope=foo, <baz.js>; "
-      "rel=serviceworker; scope=scope",
+      "rel=serviceworker; scope=scope; usecache",
       context_wrapper());
   base::RunLoop().RunUntilIdle();
 
   std::vector<ServiceWorkerRegistrationInfo> registrations = GetRegistrations();
   ASSERT_EQ(2u, registrations.size());
   EXPECT_EQ(GURL("https://example.com/foobar/foo"), registrations[0].pattern);
   EXPECT_EQ(GURL("https://example.com/foobar/bar.js"),
             registrations[0].active_version.script_url);
+  EXPECT_FALSE(registrations[0].use_cache);
   EXPECT_EQ(GURL("https://example.com/foobar/scope"), registrations[1].pattern);
   EXPECT_EQ(GURL("https://example.com/foobar/baz.js"),
             registrations[1].active_version.script_url);
+  EXPECT_TRUE(registrations[1].use_cache);
 }
 
 TEST_F(LinkHeaderServiceWorkerTest,
        InstallServiceWorker_ValidAndInvalidValues) {
   CreateDocumentProviderHost();
   ProcessLinkHeaderForRequest(
       CreateSubresourceRequest(GURL("https://example.com/foobar/")).get(),
       "<https://google.com/bar.js>; rel=serviceworker; scope=foo, <baz.js>; "
       "rel=serviceworker; scope=scope",
       context_wrapper());
@@ skipping 32 matching lines @@
 
   ProcessLinkHeaderForRequest(request.get(), "<../foo.js>; rel=serviceworker",
                               context_wrapper());
   base::RunLoop().RunUntilIdle();
 
   std::vector<ServiceWorkerRegistrationInfo> registrations = GetRegistrations();
   ASSERT_EQ(1u, registrations.size());
   EXPECT_EQ(GURL("https://example.com/foo/"), registrations[0].pattern);
   EXPECT_EQ(GURL("https://example.com/foo/foo.js"),
             registrations[0].active_version.script_url);
+  EXPECT_FALSE(registrations[0].use_cache);
 }
 
 TEST_F(LinkHeaderServiceWorkerTest,
        InstallServiceWorker_NavigationToInsecureContext) {
   CreateDocumentProviderHost();
   provider_host()->SetDocumentUrl(GURL("http://example.com/foo/bar/"));
   ProcessLinkHeaderForRequest(CreateRequest(GURL("http://example.com/foo/bar/"),
                                             RESOURCE_TYPE_MAIN_FRAME)
                                   .get(),
                               "<../foo.js>; rel=serviceworker",
@@ skipping 44 matching lines @@
   ProcessLinkHeaderForRequest(
       CreateSubresourceRequest(GURL("https://example.com/foo/bar/")).get(),
       "<../foo.js>; rel=serviceworker", context_wrapper());
   base::RunLoop().RunUntilIdle();
 
   std::vector<ServiceWorkerRegistrationInfo> registrations = GetRegistrations();
   ASSERT_EQ(1u, registrations.size());
 }
 
 }  // namespace content