Implement updateViaCache flag and no-cache by default for main service worker scripts

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/serviceworkers/ServiceWorkerRegistration.h"
 
 #include <memory>
 #include <utility>
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ScriptPromise.h"
@@ skipping 70 matching lines @@
 NavigationPreloadManager* ServiceWorkerRegistration::navigationPreload() {
   if (!navigation_preload_)
     navigation_preload_ = NavigationPreloadManager::Create(this);
   return navigation_preload_;
 }
 
 String ServiceWorkerRegistration::scope() const {
   return handle_->Registration()->Scope().GetString();
 }
 
+String ServiceWorkerRegistration::updateViaCache() const {
+  switch (handle_->Registration()->UpdateViaCache()) {
+    case WebServiceWorkerUpdateViaCache::kImports:
+      return "imports";
+    case WebServiceWorkerUpdateViaCache::kAll:
+      return "all";
+    case WebServiceWorkerUpdateViaCache::kNone:
+      return "never";

[nhiroki, 2017/07/21 04:39:46]

"never" -> "none"?

[yuryu, 2017/08/03 04:20:05]

Done.

+    default:

[nhiroki, 2017/07/21 04:39:46]

I'd prefer to avoid 'default' as much as possible because 'default' disables the
compiler's coverage check when add a new enum value. Also, can you add
NOTRACHED() check like this?

    case WebServiceWorkerUpdateViaCache::kUnknown:
    case WebServiceWorkerUpdateViaCache::kLast:
      break;
  }
  NOTREACHED();
  return "imports";

[yuryu, 2017/08/03 04:20:05]

Done.

+      return "imports";
+  }
+  return "imports";
+}
+
 ScriptPromise ServiceWorkerRegistration::update(ScriptState* script_state) {
   ServiceWorkerContainerClient* client =
       ServiceWorkerContainerClient::From(GetExecutionContext());
   if (!client || !client->Provider())
     return ScriptPromise::RejectWithDOMException(
         script_state,
         DOMException::Create(kInvalidStateError,
                              "Failed to update a ServiceWorkerRegistration: No "
                              "associated provider is available."));
 
@@ skipping 59 matching lines @@
 }
 
 void ServiceWorkerRegistration::ContextDestroyed(ExecutionContext*) {
   if (stopped_)
     return;
   stopped_ = true;
   handle_->Registration()->ProxyStopped();
 }
 
 }  // namespace blink