Implement updateViaCache flag and no-cache by default for main service worker scripts

content/common/service_worker/service_worker_types.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_SERVICE_WORKER_SERVICE_WORKER_TYPES_H_
 #define CONTENT_COMMON_SERVICE_WORKER_SERVICE_WORKER_TYPES_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 205 matching lines @@
   int handle_id;
   GURL url;
   blink::WebServiceWorkerState state;
   int64_t version_id;
 };
 
 struct CONTENT_EXPORT ServiceWorkerRegistrationObjectInfo {
   ServiceWorkerRegistrationObjectInfo();
   int handle_id;
   GURL scope;
+  bool use_cache;

[nhiroki, 2017/03/24 00:33:42]

|scope| and |use_cache| could be replaced with ServiceWorkerRegistrationOptions
(see also my following comment in this file)

[yuryu, 2017/03/28 05:08:56]

Done.

   int64_t registration_id;
 };
 
+struct CONTENT_EXPORT ServiceWorkerRegistrationAttributes {

[nhiroki, 2017/03/24 00:33:42]

"RegistrationAttributes" could sound a bit confusing. We use "VersionAttributes"
(see line 236) for updating ServiceWorker JS-object's attributes, but this
struct isn't used for such a purpose.

Since "script_url" is a required param of register() and others (pattern,
use_cache) are defined as optional params, how about excluding "script_url" from
this struct and then renaming this to ServiceWorkerRegistrationOptions? This
name would also be consistent with the spec:
https://w3c.github.io/ServiceWorker/#dictdef-registrationoptions

[falken, 2017/03/24 04:06:19]

+1, and then using this struct when possible when passing the information to
various function.

[yuryu, 2017/03/28 05:08:56]

Done.

+  GURL pattern;
+  GURL script_url;
+  bool use_cache;
+};
+
 struct ServiceWorkerVersionAttributes {
   ServiceWorkerObjectInfo installing;
   ServiceWorkerObjectInfo waiting;
   ServiceWorkerObjectInfo active;
 };
 
 class ChangedVersionAttributesMask {
  public:
   enum {
     INSTALLING_VERSION = 1 << 0,
@@ skipping 39 matching lines @@
   NavigationPreloadState();
   NavigationPreloadState(bool enabled, std::string header);
   NavigationPreloadState(const NavigationPreloadState& other);
   bool enabled;
   std::string header;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_SERVICE_WORKER_SERVICE_WORKER_TYPES_H_