Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Issue 2771803003: Don't start FRE from the login screen (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/wizard_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
index fc2123da0b0bd6a5b4d57ec5bca2ff3e2504a05c..572f11d06f35ac675ef33e3530dbfe869bd66461 100644
--- a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
@@ -16,6 +16,7 @@
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
#include "chrome/browser/chromeos/base/locale_util.h"
+#include "chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h"
#include "chrome/browser/chromeos/login/enrollment/enrollment_screen.h"
#include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper.h"
#include "chrome/browser/chromeos/login/enrollment/mock_auto_enrollment_check_screen.h"
@@ -181,19 +182,21 @@ void QuitLoopOnAutoEnrollmentProgress(
loop->Quit();
}
+} // namespace
+
+// Can't be in anonymous namespace because it needs to be a friend of
+// WizardController to access the AutoEnrollmentController.
void WaitForAutoEnrollmentState(policy::AutoEnrollmentState state) {
base::RunLoop loop;
- AutoEnrollmentController* auto_enrollment_controller =
- LoginDisplayHost::default_host()->GetAutoEnrollmentController();
std::unique_ptr<AutoEnrollmentController::ProgressCallbackList::Subscription>
progress_subscription(
- auto_enrollment_controller->RegisterProgressCallback(
- base::Bind(&QuitLoopOnAutoEnrollmentProgress, state, &loop)));
+ WizardController::default_controller()
+ ->GetAutoEnrollmentController()
+ ->RegisterProgressCallback(
+ base::Bind(&QuitLoopOnAutoEnrollmentProgress, state, &loop)));
loop.Run();
}
-} // namespace
-
using ::testing::_;
template <class T, class H>
@@ -907,9 +910,10 @@ IN_PROC_BROWSER_TEST_F(WizardControllerDeviceStateTest,
IN_PROC_BROWSER_TEST_F(WizardControllerDeviceStateTest,
ControlFlowNoForcedReEnrollmentOnFirstBoot) {
fake_statistics_provider_.ClearMachineStatistic(system::kActivateDateKey);
- EXPECT_NE(
- policy::AUTO_ENROLLMENT_STATE_NO_ENROLLMENT,
- LoginDisplayHost::default_host()->GetAutoEnrollmentController()->state());
+ EXPECT_NE(policy::AUTO_ENROLLMENT_STATE_NO_ENROLLMENT,
+ WizardController::default_controller()
+ ->GetAutoEnrollmentController()
+ ->state());
CheckCurrentScreen(OobeScreen::SCREEN_OOBE_NETWORK);
EXPECT_CALL(*mock_network_screen_, Hide()).Times(1);
@@ -932,9 +936,10 @@ IN_PROC_BROWSER_TEST_F(WizardControllerDeviceStateTest,
CheckCurrentScreen(OobeScreen::SCREEN_AUTO_ENROLLMENT_CHECK);
mock_auto_enrollment_check_screen_->RealShow();
- EXPECT_EQ(
- policy::AUTO_ENROLLMENT_STATE_NO_ENROLLMENT,
- LoginDisplayHost::default_host()->GetAutoEnrollmentController()->state());
+ EXPECT_EQ(policy::AUTO_ENROLLMENT_STATE_NO_ENROLLMENT,
+ WizardController::default_controller()
+ ->GetAutoEnrollmentController()
+ ->state());
}
IN_PROC_BROWSER_TEST_F(WizardControllerDeviceStateTest,
@@ -1325,7 +1330,7 @@ IN_PROC_BROWSER_TEST_F(WizardControllerCellularFirstTest, CellularFirstFlow) {
TestControlFlowMain();
}
-// TODO(dzhioev): Add test emaulating device with wrong HWID.
+// TODO(dzhioev): Add test emulating device with wrong HWID.
achuithb 2017/03/24 01:33:29 Just drop this TODO since there's no bug id
Thiemo Nagel 2017/04/12 14:30:40 Imho, missing a bug number or referencing a person
achuithb 2017/04/19 19:04:42 Perhaps the right thing to do would be to file a b
// TODO(nkostylev): Add test for WebUI accelerators http://crosbug.com/22571

Powered by Google App Engine
This is Rietveld 408576698