Don't start FRE from the login screen

chrome/browser/chromeos/login/wizard_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_WIZARD_CONTROLLER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_WIZARD_CONTROLLER_H_
 
 #include <map>
 #include <memory>
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/containers/hash_tables.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
 #include "chrome/browser/chromeos/login/screen_manager.h"
 #include "chrome/browser/chromeos/login/screens/base_screen_delegate.h"
 #include "chrome/browser/chromeos/login/screens/controller_pairing_screen.h"
 #include "chrome/browser/chromeos/login/screens/eula_screen.h"
 #include "chrome/browser/chromeos/login/screens/hid_detection_screen.h"
 #include "chrome/browser/chromeos/login/screens/host_pairing_screen.h"
 #include "chrome/browser/chromeos/login/screens/network_screen.h"
 #include "chrome/browser/chromeos/login/screens/reset_screen.h"
+#include "chrome/browser/chromeos/policy/auto_enrollment_client.h"
 #include "chrome/browser/chromeos/policy/enrollment_config.h"
 
 class PrefService;
 
 namespace pairing_chromeos {
 class ControllerPairingController;
 class HostPairingController;
 class SharkConnectionListener;
 }
 
 namespace chromeos {
 
+class AutoEnrollmentController;
 class ErrorScreen;
 struct Geoposition;
 class LoginDisplayHost;
 class LoginScreenContext;
 class OobeUI;
 class SimpleGeolocationProvider;
 class TimeZoneProvider;
 struct TimeZoneResponseData;
 
 // Class that manages control flow between wizard screens. Wizard controller
@@ skipping 246 matching lines @@
   void OnSetHostNetworkSuccessful();
   void OnSetHostNetworkFailed();
 
   // Start the enrollment screen using the config from
   // |prescribed_enrollment_config_|. If |force_interactive| is true,
   // the user will be presented with a manual enrollment screen requiring
   // Gaia credentials. If it is false, the screen may return after trying
   // attestation-based enrollment if appropriate.
   void StartEnrollmentScreen(bool force_interactive);
 
+  // Returns auto enrollment controller (lazily initializes one if it doesn't
+  // exist already).
+  AutoEnrollmentController* GetAutoEnrollmentController();
+
+  std::unique_ptr<AutoEnrollmentController> auto_enrollment_controller_;
   std::unique_ptr<ScreenManager> screen_manager_;
 
   // Whether to skip any screens that may normally be shown after login
   // (registration, Terms of Service, user image selection).
   static bool skip_post_login_screens_;
 
   static bool zero_delay_enabled_;
 
   // Screen that's currently active.
   BaseScreen* current_screen_ = nullptr;
@@ skipping 54 matching lines @@
 
   // Indicates that once image selection screen finishes we should return to
   // a previous screen instead of proceeding with usual flow.
   bool user_image_screen_return_to_previous_hack_ = false;
 
   // Non-owning pointer to local state used for testing.
   static PrefService* local_state_for_testing_;
 
   FRIEND_TEST_ALL_PREFIXES(EnrollmentScreenTest, TestCancel);
   FRIEND_TEST_ALL_PREFIXES(WizardControllerFlowTest, Accelerators);
+  FRIEND_TEST_ALL_PREFIXES(WizardControllerDeviceStateTest,
+                           ControlFlowNoForcedReEnrollmentOnFirstBoot);
+  friend class WizardControllerBrokenLocalStateTest;
   friend class WizardControllerFlowTest;
   friend class WizardControllerOobeResumeTest;
   friend class WizardInProcessBrowserTest;
-  friend class WizardControllerBrokenLocalStateTest;
+  friend void WaitForAutoEnrollmentState(policy::AutoEnrollmentState);

[achuithb, 2017/03/24 01:33:29]

Are there examples of friend functions like this? It feels like it might be
better to wrap this in a class.

[Thiemo Nagel, 2017/04/12 14:30:40]

I've counted 244 occurrences:
https://cs.chromium.org/search/?q=friend%5C+.*%5C(+-file:.*.pb.h+-file:third_...

I don't mind either way, though.  Thus I've made the free function a member of
WizardControllerDeviceStateTest.

 
   std::unique_ptr<AccessibilityStatusSubscription> accessibility_subscription_;
 
   std::unique_ptr<SimpleGeolocationProvider> geolocation_provider_;
   std::unique_ptr<TimeZoneProvider> timezone_provider_;
 
   // Pairing controller for shark devices.
   std::unique_ptr<pairing_chromeos::ControllerPairingController>
       shark_controller_;
 
@@ skipping 16 matching lines @@
   BaseScreen* hid_screen_ = nullptr;
 
   base::WeakPtrFactory<WizardController> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WizardController);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_WIZARD_CONTROLLER_H_