FrameFetchContext should not always respect conditional requests

third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

 /*
  * Copyright (c) 2015, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 530 matching lines @@
   ClientHintsPreferences preferences;
   preferences.setShouldSendDPR(true);
   preferences.setShouldSendResourceWidth(true);
   preferences.setShouldSendViewportWidth(true);
   document->clientHintsPreferences().updateFrom(preferences);
   expectHeader("http://www.example.com/1.gif", "DPR", true, "1");
   expectHeader("http://www.example.com/1.gif", "Width", true, "400", 400);
   expectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "500");
 }
 
-TEST_F(FrameFetchContextTest, MainResource) {
+TEST_F(FrameFetchContextTest, MainResourceCachePolicy) {
   // Default case
   ResourceRequest request("http://www.example.com");
   EXPECT_EQ(WebCachePolicy::UseProtocolCachePolicy,
             fetchContext->resourceRequestCachePolicy(
                 request, Resource::MainResource, FetchRequest::NoDefer));
 
   // Post
   ResourceRequest postRequest("http://www.example.com");
   postRequest.setHTTPMethod("POST");
   EXPECT_EQ(WebCachePolicy::ValidatingCacheData,
@@ skipping 35 matching lines @@
             childFetchContext->resourceRequestCachePolicy(
                 request, Resource::MainResource, FetchRequest::NoDefer));
 
   // Child frame as part of reload bypassing cache
   document->loader()->setLoadType(FrameLoadTypeReloadBypassingCache);
   EXPECT_EQ(WebCachePolicy::BypassingCache,
             childFetchContext->resourceRequestCachePolicy(
                 request, Resource::MainResource, FetchRequest::NoDefer));
 }
 
+TEST_F(FrameFetchContextTest, SubResourceCachePolicy) {
+  // Default case
+  ResourceRequest request("http://www.example.com/mock");
+  EXPECT_EQ(WebCachePolicy::UseProtocolCachePolicy,
+            fetchContext->resourceRequestCachePolicy(request, Resource::Mock,
+                                                     FetchRequest::NoDefer));
+
+  // FrameLoadTypeReload should not affect sub-resources
+  document->loader()->setLoadType(FrameLoadTypeReload);
+  EXPECT_EQ(WebCachePolicy::UseProtocolCachePolicy,
+            fetchContext->resourceRequestCachePolicy(request, Resource::Mock,
+                                                     FetchRequest::NoDefer));
+
+  // Conditional request
+  document->loader()->setLoadType(FrameLoadTypeStandard);
+  ResourceRequest conditional("http://www.example.com/mock");
+  conditional.setHTTPHeaderField(HTTPNames::If_Modified_Since, "foo");
+  EXPECT_EQ(WebCachePolicy::ValidatingCacheData,
+            fetchContext->resourceRequestCachePolicy(
+                conditional, Resource::Mock, FetchRequest::NoDefer));
+
+  // FrameLoadTypeReloadBypassingCache
+  document->loader()->setLoadType(FrameLoadTypeReloadBypassingCache);
+  EXPECT_EQ(WebCachePolicy::BypassingCache,
+            fetchContext->resourceRequestCachePolicy(request, Resource::Mock,
+                                                     FetchRequest::NoDefer));
+
+  // FrameLoadTypeReloadBypassingCache with a conditional request
+  document->loader()->setLoadType(FrameLoadTypeReloadBypassingCache);
+  EXPECT_EQ(WebCachePolicy::BypassingCache,
+            fetchContext->resourceRequestCachePolicy(
+                conditional, Resource::Mock, FetchRequest::NoDefer));
+
+  // Back/forward navigation
+  document->loader()->setLoadType(FrameLoadTypeBackForward);
+  EXPECT_EQ(WebCachePolicy::ReturnCacheDataElseLoad,
+            fetchContext->resourceRequestCachePolicy(request, Resource::Mock,
+                                                     FetchRequest::NoDefer));
+
+  // Back/forward navigation with a conditional request
+  document->loader()->setLoadType(FrameLoadTypeBackForward);
+  EXPECT_EQ(WebCachePolicy::ReturnCacheDataElseLoad,
+            fetchContext->resourceRequestCachePolicy(
+                conditional, Resource::Mock, FetchRequest::NoDefer));
+}
+
 TEST_F(FrameFetchContextTest, SetFirstPartyCookieAndRequestorOrigin) {
   struct TestCase {
     const char* documentURL;
     bool documentSandboxed;
     const char* requestorOrigin;  // "" => unique origin
     WebURLRequest::FrameType frameType;
     const char* serializedOrigin;  // "" => unique origin
   } cases[] = {
       // No document origin => unique request origin
       {"", false, "", WebURLRequest::FrameTypeNone, "null"},
@@ skipping 314 matching lines @@
   setFilterPolicy(WebDocumentSubresourceFilter::WouldDisallow);
 
   EXPECT_EQ(ResourceRequestBlockedReason::None, canRequest());
   EXPECT_EQ(0, getFilteredLoadCallCount());
 
   EXPECT_EQ(ResourceRequestBlockedReason::None, canRequestPreload());
   EXPECT_EQ(0, getFilteredLoadCallCount());
 }
 
 }  // namespace blink