Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: chrome/browser/android/webapk/webapk_update_data_fetcher.cc

Issue 2771793003: Move timeout timer into WebApkIconHasher (Closed)
Patch Set: Remove weakptr and use unretained Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapk/webapk_installer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapk/webapk_update_data_fetcher.cc
diff --git a/chrome/browser/android/webapk/webapk_update_data_fetcher.cc b/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
index 5b8e87a48e4dd5ab15fef5efee4a6b1d0c66e6fe..2443cd0722bd8ef894a0ef5591ad6448bde8ae89 100644
--- a/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
+++ b/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
@@ -152,13 +152,14 @@ void WebApkUpdateDataFetcher::OnDidGetInstallableData(
info_.best_primary_icon_url = data.primary_icon_url;
best_primary_icon_ = *data.primary_icon;
- icon_hasher_.reset(new WebApkIconHasher());
Profile* profile =
Profile::FromBrowserContext(web_contents()->GetBrowserContext());
- icon_hasher_->DownloadAndComputeMurmur2Hash(
+
+ icon_hasher_.reset(new WebApkIconHasher(
profile->GetRequestContext(), data.primary_icon_url,
base::Bind(&WebApkUpdateDataFetcher::OnGotIconMurmur2Hash,
- weak_ptr_factory_.GetWeakPtr()));
+ weak_ptr_factory_.GetWeakPtr())));
+ icon_hasher_->DownloadAndComputeMurmur2Hash();
}
void WebApkUpdateDataFetcher::OnGotIconMurmur2Hash(
« no previous file with comments | « chrome/browser/android/webapk/webapk_installer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698