Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2491)

Unified Diff: courgette/disassembler_win32.h

Issue 2771753004: [Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there. (Closed)
Patch Set: Fix signed/unsigned comparison issue in test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/disassembler_elf_32_x86_unittest.cc ('k') | courgette/disassembler_win32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/disassembler_win32.h
diff --git a/courgette/disassembler_win32.h b/courgette/disassembler_win32.h
index c6d986f5db2a30c1005a45581e0dfeaa0229e13e..d2df58c08df6004f4c188882d71dcaae07369a28 100644
--- a/courgette/disassembler_win32.h
+++ b/courgette/disassembler_win32.h
@@ -15,13 +15,13 @@
#include "base/macros.h"
#include "courgette/disassembler.h"
#include "courgette/image_utils.h"
+#include "courgette/instruction_utils.h"
#include "courgette/memory_allocator.h"
#include "courgette/types_win_pe.h"
namespace courgette {
class AssemblyProgram;
-class InstructionReceptor;
class DisassemblerWin32 : public Disassembler {
public:
@@ -34,7 +34,6 @@ class DisassemblerWin32 : public Disassembler {
uint64_t image_base() const override { return image_base_; }
RVA PointerToTargetRVA(const uint8_t* p) const override = 0;
bool ParseHeader() override;
- bool Disassemble(AssemblyProgram* program) override;
// Exposed for test purposes
bool has_text_section() const { return has_text_section_; }
@@ -60,9 +59,13 @@ class DisassemblerWin32 : public Disassembler {
void ParseRel32RelocsFromSections();
// Disassembler interfaces.
+ bool ExtractAbs32Locations() override;
+ bool ExtractRel32Locations() override;
RvaVisitor* CreateAbs32TargetRvaVisitor() override;
RvaVisitor* CreateRel32TargetRvaVisitor() override;
void RemoveUnusedRel32Locations(AssemblyProgram* program) override;
+ InstructionGenerator GetInstructionGenerator(
+ AssemblyProgram* program) override;
DisassemblerWin32(const uint8_t* start, size_t length);
« no previous file with comments | « courgette/disassembler_elf_32_x86_unittest.cc ('k') | courgette/disassembler_win32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698