courgette/disassembler_elf_32_x86.cc - Issue 2771753004: [Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler_elf_32_x86.cc

Issue 2771753004: [Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there. (Closed)

Patch Set: Fix signed/unsigned comparison issue in test. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/disassembler_elf_32_x86.cc

diff --git a/courgette/disassembler_elf_32_x86.cc b/courgette/disassembler_elf_32_x86.cc

index a14475fc5b4019c7026932c067e595817611d68e..b62b293f4ce76e432ebd64415ff924b5f76df088 100644

--- a/courgette/disassembler_elf_32_x86.cc

+++ b/courgette/disassembler_elf_32_x86.cc

@@ -106,7 +106,7 @@ CheckBool DisassemblerElf32X86::ParseRelocationSection(

if (abs32_locations_.size() > section_relocs_count)

match = false;

- std::vector<RVA>::iterator reloc_iter = abs32_locations_.begin();

+ std::vector<RVA>::const_iterator reloc_iter = abs32_locations_.begin();

while (match && (reloc_iter != abs32_locations_.end())) {

if (section_relocs_iter->r_info != R_386_RELATIVE ||

« no previous file with comments | « courgette/disassembler_elf_32_arm.cc ('k') | courgette/disassembler_elf_32_x86_unittest.cc » ('j') | no next file with comments »