Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: courgette/assembly_program.cc

Issue 2771753004: [Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there. (Closed)
Patch Set: Fix signed/unsigned comparison issue in test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/assembly_program.h ('k') | courgette/disassembler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/assembly_program.cc
diff --git a/courgette/assembly_program.cc b/courgette/assembly_program.cc
index 77d73b9f13b8bd9030c0b3c775ba36097d5cc962..fdd312a585a53cf2edac8cce01dbe26ee339d42a 100644
--- a/courgette/assembly_program.cc
+++ b/courgette/assembly_program.cc
@@ -309,14 +309,14 @@ CheckBool AssemblyProgram::GenerateInstructions(
const InstructionGenerator& gen) {
// Pass 1: Count the space needed to store instructions.
InstructionCountReceptor count_receptor;
- if (!gen.Run(this, &count_receptor))
+ if (!gen.Run(&count_receptor))
return false;
// Pass 2: Emit all instructions to preallocated buffer (uses Phase 1 count).
InstructionStoreReceptor store_receptor(this);
- // TODO(huangs): 2016/11: Pass |count_receptor_->size()| to |store_receptor_|
+ // TODO(huangs): 2017/03: Pass |count_receptor->size()| to |store_receptor_|
// to reserve space for raw data.
- return gen.Run(this, &store_receptor);
+ return gen.Run(&store_receptor);
}
CheckBool AssemblyProgram::Emit(ScopedInstruction instruction) {
« no previous file with comments | « courgette/assembly_program.h ('k') | courgette/disassembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698