Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 27717003: HeapProfiler: integrate FindUntrackedObjects into js code. (Closed)

Created:
7 years, 2 months ago by loislo
Modified:
7 years, 2 months ago
CC:
v8-dev, yurys, alph
Visibility:
Public.

Description

HeapProfiler: integrate FindUntrackedObjects into js code. In some cases we would like to check untracked objects right from the js code. Otherwise the objects might be collected rigth before check. BUG=none R=hpayer@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17270

Patch Set 1 #

Patch Set 2 : test fixed #

Patch Set 3 : cosmetic change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -5 lines) Patch
M src/builtins.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +56 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
loislo
7 years, 2 months ago (2013-10-17 14:57:40 UTC) #1
loislo
7 years, 2 months ago (2013-10-18 10:06:43 UTC) #2
yurys
lgtm
7 years, 2 months ago (2013-10-18 10:40:50 UTC) #3
Hannes Payer (out of office)
lgtm
7 years, 2 months ago (2013-10-18 11:13:07 UTC) #4
loislo
7 years, 2 months ago (2013-10-18 11:25:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r17270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698