Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2383)

Unified Diff: ash/common/shelf/shelf_delegate.h

Issue 2771663002: mash: Refactor ChromeLauncherController's ShelfDelegate code. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/test/test_shelf_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/shelf_delegate.h
diff --git a/ash/common/shelf/shelf_delegate.h b/ash/common/shelf/shelf_delegate.h
index 6a8d79d42af27ffcfaf9b3f110fbfda2a1d3e85e..f15920f3fc8c9bcb535b181f5460cf59a1209fbf 100644
--- a/ash/common/shelf/shelf_delegate.h
+++ b/ash/common/shelf/shelf_delegate.h
@@ -17,7 +17,8 @@ class ASH_EXPORT ShelfDelegate {
public:
virtual ~ShelfDelegate() {}
- // Get the shelf ID from an application ID.
+ // Get the shelf ID from an application ID. Returns kInvalidShelfID if the
+ // app id is unknown, or has no associated ShelfID.
virtual ShelfID GetShelfIDForAppID(const std::string& app_id) = 0;
// Get the shelf ID from an application ID and a launch ID.
@@ -25,17 +26,14 @@ class ASH_EXPORT ShelfDelegate {
// multiple shelf items per app. This id is used together with the app_id to
// uniquely identify each shelf item that has the same app_id.
// For example, a single virtualization app might want to show different
- // shelf icons for different remote apps.
+ // shelf icons for different remote apps. Returns kInvalidShelfID if the app
+ // id is unknown or has no associated ShelfID.
virtual ShelfID GetShelfIDForAppIDAndLaunchID(
const std::string& app_id,
const std::string& launch_id) = 0;
- // Checks whether a mapping exists from the ShelfID |id| to an app id.
- virtual bool HasShelfIDToAppIDMapping(ShelfID id) const = 0;
-
- // Get the application ID for a given shelf ID.
- // |HasShelfIDToAppIDMapping(ShelfID)| should be called first to ensure the
- // ShelfID can be successfully mapped to an app id.
+ // Get the application ID for a given shelf ID. Returns an empty string for
+ // an unknown or invalid ShelfID.
virtual const std::string& GetAppIDForShelfID(ShelfID id) = 0;
// Pins an app with |app_id| to shelf. A running instance will get pinned.
« no previous file with comments | « no previous file | ash/common/test/test_shelf_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698