Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Issue 2771653002: Completion boilerplate for Flutter cons children (flutter-intellij#463) (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
index f9c6a455878a067f0be6961396d64d843b289998..eec6ebf56f285f1700b91a1359adc3574ae085c9 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
@@ -11,6 +11,7 @@ import 'package:analysis_server/plugin/protocol/protocol.dart' as protocol
import 'package:analysis_server/plugin/protocol/protocol.dart'
hide Element, ElementKind;
import 'package:analysis_server/plugin/protocol/protocol.dart';
+import 'package:analysis_server/src/ide_options.dart';
import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';
import 'package:analysis_server/src/services/completion/completion_core.dart';
import 'package:analysis_server/src/services/completion/completion_performance.dart';
@@ -18,6 +19,8 @@ import 'package:analysis_server/src/services/completion/dart/completion_manager.
show DartCompletionRequestImpl, ReplacementRange;
import 'package:analysis_server/src/services/index/index.dart';
import 'package:analysis_server/src/services/search/search_engine_internal.dart';
+import 'package:analyzer/file_system/file_system.dart';
+import 'package:analyzer/source/package_map_resolver.dart';
import 'package:analyzer/src/dart/analysis/ast_provider_context.dart';
import 'package:analyzer/src/dart/analysis/driver.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -25,6 +28,7 @@ import 'package:analyzer/task/dart.dart';
import 'package:test/test.dart';
import '../../../abstract_context.dart';
+import '../../correction/flutter_util.dart';
int suggestionComparator(CompletionSuggestion s1, CompletionSuggestion s2) {
String c1 = s1.completion.toLowerCase();
@@ -476,7 +480,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
Duration.ZERO, () => computeLibrariesContaining(times - 1));
}
- Future computeSuggestions([int times = 200]) async {
+ Future computeSuggestions({int times = 200, IdeOptions options}) async {
AnalysisResult analysisResult = null;
if (enableNewAnalysisDriver) {
analysisResult = await driver.getResult(testFile);
@@ -491,7 +495,8 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
searchEngine,
testSource,
completionOffset,
- new CompletionPerformance());
+ new CompletionPerformance(),
+ options);
// Build the request
Completer<DartCompletionRequest> requestCompleter =
@@ -522,6 +527,34 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
expect(suggestions, isNotNull, reason: 'expected suggestions');
}
+ /**
+ * Configures the [SourceFactory] to have the `flutter` package in
+ * `/packages/flutter/lib` folder.
+ */
+ void configureFlutterPkg(Map<String, String> pathToCode) {
+ pathToCode.forEach((path, code) {
+ provider.newFile('$flutterPkgLibPath/$path', code);
+ });
+ // configure SourceFactory
+ Folder myPkgFolder = provider.getResource(flutterPkgLibPath);
+ UriResolver pkgResolver = new PackageMapUriResolver(provider, {
+ 'flutter': [myPkgFolder]
+ });
+ SourceFactory sourceFactory = new SourceFactory(
+ [new DartUriResolver(sdk), pkgResolver, resourceResolver]);
+ if (enableNewAnalysisDriver) {
+ driver.configure(sourceFactory: sourceFactory);
+ } else {
+ context.sourceFactory = sourceFactory;
+ }
+ // force 'flutter' resolution
+ addSource(
+ '/tmp/other.dart',
+ pathToCode.keys
+ .map((path) => "import 'package:flutter/$path';")
+ .join('\n'));
+ }
+
DartCompletionContributor createContributor();
void failedCompletion(String message,

Powered by Google App Engine
This is Rietveld 408576698