Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2771653002: Completion boilerplate for Flutter cons children (flutter-intellij#463) (Closed)

Created:
3 years, 9 months ago by pquitslund
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Completion boilerplate for Flutter cons children (flutter-intellij#463) * plumbs IDE options into completion requests * simple POC test More tests and a bit of cleanup to come. R=brianwilkerson@google.com See: https://github.com/flutter/flutter-intellij/issues/463 Committed: https://github.com/dart-lang/sdk/commit/df06af12eb068773d3780f516dca99c29baa5972

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revert format. #

Patch Set 3 : Really revert formatting. #

Patch Set 4 : Format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 2 3 2 chunks +45 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/utilities.dart View 1 2 3 3 chunks +9 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 1 2 3 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
3 years, 9 months ago (2017-03-22 21:51:03 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2771653002/diff/1/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart File pkg/analysis_server/lib/src/services/completion/dart/utilities.dart (right): https://codereview.chromium.org/2771653002/diff/1/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart#newcode75 pkg/analysis_server/lib/src/services/completion/dart/utilities.dart:75: if (options?.generateFlutterWidgetChildrenBoilerPlate == true) { I think I'd ...
3 years, 9 months ago (2017-03-22 22:05:46 UTC) #3
pquitslund
On 2017/03/22 22:05:46, Brian Wilkerson wrote: > lgtm > > https://codereview.chromium.org/2771653002/diff/1/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart > File pkg/analysis_server/lib/src/services/completion/dart/utilities.dart > ...
3 years, 9 months ago (2017-03-22 22:13:30 UTC) #4
pquitslund
3 years, 9 months ago (2017-03-22 22:14:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
df06af12eb068773d3780f516dca99c29baa5972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698