Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 277163002: Adds the ability to filter bench expectations in builder/config level. (Closed)

Created:
6 years, 7 months ago by benchen
Modified:
6 years, 7 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com, kelvinly
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Adds the ability to filter bench expectations in builder/config level. BUG=skia:2539 NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14694

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M bench/gen_bench_expectations.py View 4 chunks +21 lines, -7 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
benchen
6 years, 7 months ago (2014-05-12 11:39:18 UTC) #1
rmistry
LGTM https://codereview.chromium.org/277163002/diff/1/bench/gen_bench_expectations.py File bench/gen_bench_expectations.py (right): https://codereview.chromium.org/277163002/diff/1/bench/gen_bench_expectations.py#newcode36 bench/gen_bench_expectations.py:36: ] What do you think about having an ...
6 years, 7 months ago (2014-05-12 11:56:56 UTC) #2
benchen
The CQ bit was checked by bensong@google.com
6 years, 7 months ago (2014-05-12 14:36:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/277163002/1
6 years, 7 months ago (2014-05-12 14:36:37 UTC) #4
commit-bot: I haz the power
Change committed as 14694
6 years, 7 months ago (2014-05-12 14:36:45 UTC) #5
benchen
6 years, 7 months ago (2014-05-12 15:00:40 UTC) #6
Message was sent while issue was closed.
On 2014/05/12 11:56:56, rmistry wrote:
> LGTM
> 
>
https://codereview.chromium.org/277163002/diff/1/bench/gen_bench_expectations.py
> File bench/gen_bench_expectations.py (right):
> 
>
https://codereview.chromium.org/277163002/diff/1/bench/gen_bench_expectations...
> bench/gen_bench_expectations.py:36: ]
> What do you think about having an easy to find JSON or CSV file that contains
> all the entries to exclude.
> 
> Generalizing this further we could have a JSON file for bench expectations
that
> contains ENTRIES_TO_EXCLUDE, CONFIGS_TO_INCLUDE and the UPPER and LOWER
ranges.
> Something to think about, does not have to be part of this CL.

Thanks for the suggestion! Sounds like a good idea if we find that the list
grows over time. Maybe a TODO for Kelvin :)

Powered by Google App Engine
This is Rietveld 408576698