Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 2771603002: [WIP] Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
index 120d0f244ac4df080224f38d0047cad9ffc10689..c11dfc1c572907a451ba790b4e7a33364c4944f7 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -302,8 +302,7 @@ void SpellChecker::advanceToNextMisspelling(bool startBeforeSelection) {
.build());
frame().selection().revealSelection();
spellCheckerClient().updateSpellingUIWithMisspelledWord(misspelledWord);
- frame().document()->markers().addSpellingMarker(
- misspellingRange.startPosition(), misspellingRange.endPosition());
+ frame().document()->markers().addSpellingMarker(misspellingRange);
}
}
@@ -550,11 +549,9 @@ static void addMarker(Document* document,
DCHECK(type == DocumentMarker::Grammar || type == DocumentMarker::Spelling);
if (type == DocumentMarker::Grammar) {
Xiaocheng 2017/03/22 21:21:01 nit: no need to have braces now.
- document->markers().addGrammarMarker(
- rangeToMark.startPosition(), rangeToMark.endPosition(), description);
+ document->markers().addGrammarMarker(rangeToMark, description);
} else {
- document->markers().addSpellingMarker(
- rangeToMark.startPosition(), rangeToMark.endPosition(), description);
+ document->markers().addSpellingMarker(rangeToMark, description);
}
}

Powered by Google App Engine
This is Rietveld 408576698