Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2771603002: [WIP] Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
index 5b46a96cc3e4b46234b9885ed4e2c95a28259f69..25da582651273e7d468b5a740df367e8e6e3667a 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
@@ -444,8 +444,8 @@ void InputMethodController::addCompositionUnderlines(
continue;
document().markers().addCompositionMarker(
- ephemeralLineRange.startPosition(), ephemeralLineRange.endPosition(),
- underline.color(), underline.thick(), underline.backgroundColor());
+ ephemeralLineRange, underline.color(), underline.thick(),
+ underline.backgroundColor());
}
}
@@ -691,8 +691,7 @@ void InputMethodController::setComposition(
if (underlines.isEmpty()) {
document().markers().addCompositionMarker(
- m_compositionRange->startPosition(), m_compositionRange->endPosition(),
- Color::black, false,
+ EphemeralRange(m_compositionRange), Color::black, false,
LayoutTheme::theme().platformDefaultCompositionBackgroundColor());
return;
}

Powered by Google App Engine
This is Rietveld 408576698