third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js - Issue 2771533004: [DevTools] Make timeline popover easier to use on small screens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

Issue 2771533004: [DevTools] Make timeline popover easier to use on small screens (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

index 8a52f32e8cc75c760c757aa549a10b132b5375ac..781015b80ba5d1a8f9871c2e46bd1aec98a234de 100644

--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

@@ -76,6 +76,7 @@ PerfUI.TimelineOverviewPane = class extends UI.VBox {

return false;

var content = new PerfUI.TimelineOverviewPane.PopoverContents();

this._popoverContents = content.contentElement.createChild('div');

+ this._popoverContents.addEventListener('click', () => this._popoverHelper.hidePopover());

this._popoverContents.appendChild(fragment);

this._popover = popover;

content.show(popover.contentElement);

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js » ('J')