Revert "Send click event after pointer capturing retarget"

third_party/WebKit/Source/core/input/MouseEventManager.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/input/MouseEventManager.h"
 
 #include "core/clipboard/DataObject.h"
 #include "core/clipboard/DataTransfer.h"
 #include "core/dom/Element.h"
 #include "core/dom/ElementTraversal.h"
@@ skipping 214 matching lines @@
   if (targetNode && targetNode->isTextNode())
     targetNode = FlatTreeTraversal::parent(*targetNode);
 
   setNodeUnderMouse(targetNode, canvasRegionId, webMouseEvent);
 
   return dispatchMouseEvent(m_nodeUnderMouse, eventType, webMouseEvent,
                             canvasRegionId, nullptr);
 }
 
 WebInputEventResult MouseEventManager::dispatchMouseClickIfNeeded(
-    Node* target,
-    const WebMouseEvent& mouseEvent,
-    const String& canvasRegionId) {
+    const MouseEventWithHitTestResults& mev) {
   // We only prevent click event when the click may cause contextmenu to popup.
   // However, we always send auxclick.
   bool contextMenuEvent =
       !RuntimeEnabledFeatures::auxclickEnabled() &&
-      mouseEvent.button == WebPointerProperties::Button::Right;
+      mev.event().button == WebPointerProperties::Button::Right;
 #if OS(MACOSX)
   // FIXME: The Mac port achieves the same behavior by checking whether the
   // context menu is currently open in WebPage::mouseEvent(). Consider merging
   // the implementations.
-  if (mouseEvent.button == WebPointerProperties::Button::Left &&
-      mouseEvent.modifiers() & WebInputEvent::Modifiers::ControlKey)
+  if (mev.event().button == WebPointerProperties::Button::Left &&
+      mev.event().modifiers() & WebInputEvent::Modifiers::ControlKey)
     contextMenuEvent = true;
 #endif
 
   WebInputEventResult clickEventResult = WebInputEventResult::NotHandled;
-  const bool shouldDispatchClickEvent = m_clickCount > 0 && !contextMenuEvent &&
-                                        target && m_clickNode &&
-                                        target->canParticipateInFlatTree() &&
-                                        m_clickNode->canParticipateInFlatTree();
+  const bool shouldDispatchClickEvent =
+      m_clickCount > 0 && !contextMenuEvent && mev.innerNode() && m_clickNode &&
+      mev.innerNode()->canParticipateInFlatTree() &&
+      m_clickNode->canParticipateInFlatTree() &&
+      !(m_frame->eventHandler().selectionController().hasExtendedSelection() &&
+        isLinkSelection(mev));
   if (shouldDispatchClickEvent) {
     Node* clickTargetNode = nullptr;
     // Updates distribution because a 'mouseup' event listener can make the
     // tree dirty at dispatchMouseEvent() invocation above.
     // Unless distribution is updated, commonAncestor would hit ASSERT.
-    if (m_clickNode == target) {
+    if (m_clickNode == mev.innerNode()) {
       clickTargetNode = m_clickNode;
       clickTargetNode->updateDistribution();
-    } else if (m_clickNode->document() == target->document()) {
+    } else if (m_clickNode->document() == mev.innerNode()->document()) {
       m_clickNode->updateDistribution();
-      target->updateDistribution();
-      clickTargetNode = target->commonAncestor(
+      mev.innerNode()->updateDistribution();
+      clickTargetNode = mev.innerNode()->commonAncestor(
           *m_clickNode, EventHandlingUtil::parentForClickEvent);
     }
     if (clickTargetNode) {
       clickEventResult = dispatchMouseEvent(
           clickTargetNode,
           !RuntimeEnabledFeatures::auxclickEnabled() ||
-                  (mouseEvent.button == WebPointerProperties::Button::Left)
+                  (mev.event().button == WebPointerProperties::Button::Left)
               ? EventTypeNames::click
               : EventTypeNames::auxclick,
-          mouseEvent, canvasRegionId, nullptr);
+          mev.event(), mev.canvasRegionId(), nullptr);
     }
   }
   return clickEventResult;
 }
 
 void MouseEventManager::fakeMouseMoveEventTimerFired(TimerBase* timer) {
   TRACE_EVENT0("input", "MouseEventManager::fakeMouseMoveEventTimerFired");
   DCHECK(timer == &m_fakeMouseMoveEventTimer);
   DCHECK(!m_mousePressed);
 
@@ skipping 279 matching lines @@
   m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
   if (FrameView* frameView = m_frame->view()) {
     if (frameView->isPointInScrollbarCorner(
             flooredIntPoint(event.event().positionInRootFrame())))
       return WebInputEventResult::NotHandled;
   }
 
   bool singleClick = event.event().clickCount <= 1;
 
-  m_mouseDownMayStartDrag = singleClick && !isSelectionOverLink(event) &&
-                            !isExtendingSelection(event);
+  m_mouseDownMayStartDrag =
+      singleClick && !isLinkSelection(event) && !isExtendingSelection(event);
 
   m_frame->eventHandler().selectionController().handleMousePressEvent(event);
 
   m_mouseDown = event.event();
 
   if (m_frame->document()->isSVGDocument() &&
       m_frame->document()->accessSVGExtensions().zoomAndPanEnabled()) {
     if ((event.event().modifiers() & WebInputEvent::Modifiers::ShiftKey) &&
         singleClick) {
       m_svgPan = true;
@@ skipping 432 matching lines @@
 
 void MouseEventManager::setClickCount(int clickCount) {
   m_clickCount = clickCount;
 }
 
 bool MouseEventManager::mouseDownMayStartDrag() {
   return m_mouseDownMayStartDrag;
 }
 
 }  // namespace blink