runtime/observatory/tests/service/service_kernel.status - Issue 2771443003: [kernel] Fix getter, run service tests in debug mode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/observatory/tests/service/service_kernel.status

Issue 2771443003: [kernel] Fix getter, run service tests in debug mode (Closed)

Patch Set: Re-insert assert, don't create getter for static field without initializer Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 [ $compiler == dartkp ]	5 [ $compiler == dartkp ]

6 *: Skip # Non-kernel also skips precompiled mode.	6 *: Skip # Non-kernel also skips precompiled mode.

7	7

8 [ $compiler == dartk && $mode == debug ]

9 *: Skip # ~2/3 fail because of finalization issues. Issue #29123.

10

11 [ $compiler == dartk ]	8 [ $compiler == dartk ]

12 ###	9 ###

13 ### Kernel works slightly different. There are kernel specific versions.	10 ### Kernel works slightly different. There are kernel specific versions.

14 ### These are the non-kernel specific versions so skip these tests.	11 ### These are the non-kernel specific versions so skip these tests.

15 ###	12 ###

16 add_breakpoint_rpc_test: SkipByDesign # non-kernel specific version of add_break point_rpc_kernel_test.	13 add_breakpoint_rpc_test: SkipByDesign # non-kernel specific version of add_break point_rpc_kernel_test.

17	14

18 ###	15 ###

19 ### Kernel works slightly different. At least for now allow errors.	16 ### Kernel works slightly different. At least for now allow errors.

20 ###	17 ###

(...skipping 29 matching lines...) Expand all Loading...
50 pause_on_unhandled_async_exceptions2_test: RuntimeError	47 pause_on_unhandled_async_exceptions2_test: RuntimeError

51 pause_on_unhandled_async_exceptions_test: RuntimeError	48 pause_on_unhandled_async_exceptions_test: RuntimeError

52	49

53 ###	50 ###

54 ### Uncategorized.	51 ### Uncategorized.

55 ###	52 ###

56 object_graph_vm_test: RuntimeError	53 object_graph_vm_test: RuntimeError

57	54

58 # Inherited from service.status	55 # Inherited from service.status

59 isolate_lifecycle_test: Pass, RuntimeError	56 isolate_lifecycle_test: Pass, RuntimeError

OLD	NEW

« no previous file with comments | « no previous file | runtime/vm/kernel_reader.cc » ('j') | runtime/vm/kernel_reader.cc » ('J')