[kernel] Fix getter, run service tests in debug mode

runtime/vm/kernel_to_il.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <map>
 #include <set>
 #include <string>
 
 #include "vm/kernel_to_il.h"
 
@@ skipping 3533 matching lines @@
     // initialization) and then call the implicit getter.  Thus, the getter
     // cannot contain the InitStaticField instruction that normal static getters
     // contain because it would detect spurious circular initialization when it
     // checks for the transition sentinel.
     Expression* initializer = kernel_field->initializer();
     ASSERT(initializer != NULL);
     body += Constant(constant_evaluator_.EvaluateExpression(initializer));
   } else {
     // The field always has an initializer because static fields without
     // initializers are initialized eagerly and do not have implicit getters.
-    ASSERT(field.has_initializer());

[Kevin Millikin (Google), 2017/03/22 13:09:38]

I think the ASSERT is indicating that something is not behaving the way we
expect.

The fix is probably to add this at the beginning of
KernelReader::GenerateFieldAccessors:

  if (kernel_field->IsStatic() && kernel_field->initializer() == NULL) {
    field.SetStaticValue(Instance::Handle(Z), true);
    return;
  }

     body += Constant(field);
     body += InitStaticField(field);
     body += Constant(field);
     body += LoadStaticField();
   }
   body += Return(TokenPosition::kNoSource);
 
   return new (Z) FlowGraph(*parsed_function_, graph_entry_, next_block_id_ - 1);
 }
 
@@ skipping 2878 matching lines @@
     thread->clear_sticky_error();
     return error.raw();
   }
 }
 
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)