components/media_router/issue_unittest.cc - Issue 2771413003: Move c/b/media/router/mojo/*.mojom to chrome/common/media_router/mojo/*.mojom

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/media_router/issue_unittest.cc

Issue 2771413003: Move c/b/media/router/mojo/*.mojom to chrome/common/media_router/mojo/*.mojom (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/media_router/discovery/media_sink_internal_unittest.cc ('K') | « components/media_router/issue.cc ('k') | components/media_router/media_route.h » ('j') | components/media_router/media_route_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/media/router/issue.h"	5 #include "components/media_router/issue.h"

6 #include "testing/gmock/include/gmock/gmock.h"	6 #include "testing/gmock/include/gmock/gmock.h"
	sdefresne 2017/04/03 13:34:06 nit: blank line above nit: blank line above takumif 2017/04/04 17:34:50 Done. Show quoted text On 2017/04/03 13:34:06, sdefresne wrote: > nit: blank line above Done.
7	7

8 namespace media_router {	8 namespace media_router {

9	9

10 namespace {	10 namespace {

11	11

12 IssueInfo CreateWarningIssueInfo(IssueInfo::Action action_type) {	12 IssueInfo CreateWarningIssueInfo(IssueInfo::Action action_type) {

13 IssueInfo issue("title", action_type, IssueInfo::Severity::WARNING);	13 IssueInfo issue("title", action_type, IssueInfo::Severity::WARNING);

14 issue.message = "message";	14 issue.message = "message";

15 issue.help_page_id = 12345;	15 issue.help_page_id = 12345;

16 return issue;	16 return issue;

(...skipping 90 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
107 EXPECT_EQ("", issue3.message);	107 EXPECT_EQ("", issue3.message);

108 EXPECT_EQ(IssueInfo::Action::LEARN_MORE, issue3.default_action);	108 EXPECT_EQ(IssueInfo::Action::LEARN_MORE, issue3.default_action);

109 EXPECT_FALSE(issue3.secondary_actions.empty());	109 EXPECT_FALSE(issue3.secondary_actions.empty());

110 EXPECT_EQ(1u, issue3.secondary_actions.size());	110 EXPECT_EQ(1u, issue3.secondary_actions.size());

111 EXPECT_EQ(IssueInfo::Severity::FATAL, issue3.severity);	111 EXPECT_EQ(IssueInfo::Severity::FATAL, issue3.severity);

112 EXPECT_EQ("routeid", issue3.route_id);	112 EXPECT_EQ("routeid", issue3.route_id);

113 EXPECT_TRUE(issue3.is_blocking);	113 EXPECT_TRUE(issue3.is_blocking);

114 }	114 }

115	115

116 } // namespace media_router	116 } // namespace media_router

OLD	NEW