Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2771323002: Fix package URI calculation when in third_party but not third_party/dart (Closed)

Created:
3 years, 9 months ago by skybrian
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix package URI calculation when in third_party but not third_party/dart In this case we should use a dotted package name, similar to other packages outside third_party. Previously, restoreAbsolute() didn't return a package URI at all, which would result in a relative path being suggested for a missing import. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/ef48584f1f3469c8abb51ea4f4fe3da3e886ff26

Patch Set 1 #

Patch Set 2 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M pkg/analyzer/lib/src/generated/bazel.dart View 1 1 chunk +7 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/bazel_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
skybrian
3 years, 9 months ago (2017-03-24 23:02:47 UTC) #3
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-24 23:47:16 UTC) #4
skybrian
3 years, 9 months ago (2017-03-24 23:59:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ef48584f1f3469c8abb51ea4f4fe3da3e886ff26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698