Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: runtime/vm/profiler_test.cc

Issue 2771293003: Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and st… (Closed)
Patch Set: Removed garbage code, updated status file to skip service test not supported Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/malloc_hooks.cc ('K') | « runtime/vm/profiler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler_test.cc
diff --git a/runtime/vm/profiler_test.cc b/runtime/vm/profiler_test.cc
index 5176943c54006ec7ef95479ce5f4e981f8ada696..ccada84dc3b8c8812b8727ed8832a4cabac97a60 100644
--- a/runtime/vm/profiler_test.cc
+++ b/runtime/vm/profiler_test.cc
@@ -316,6 +316,8 @@ TEST_CASE(Profiler_TrivialRecordAllocation) {
}
}
+#if defined(DART_USE_TCMALLOC) && defined(HOST_OS_LINUX) && defined(DEBUG) && \
+ defined(HOST_ARCH_x64)
DART_NOINLINE static void NativeAllocationSampleHelper(char** result) {
ASSERT(result != NULL);
@@ -522,6 +524,8 @@ ISOLATE_UNIT_TEST_CASE(Profiler_NativeAllocation) {
MallocHooks::TearDown();
FLAG_enable_malloc_hooks = enable_malloc_hooks_saved;
}
+#endif // defined(DART_USE_TCMALLOC) && !defined(PRODUCT) &&
+ // !defined(TARGET_ARCH_DBC) && !defined(HOST_OS_FUCHSIA)
TEST_CASE(Profiler_ToggleRecordAllocation) {
« runtime/vm/malloc_hooks.cc ('K') | « runtime/vm/profiler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698