Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: runtime/observatory/lib/src/elements/function_ref.dart

Issue 2771293003: Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and st… (Closed)
Patch Set: Added page to Observatory to display native memory allocation information. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/function_ref.dart
diff --git a/runtime/observatory/lib/src/elements/function_ref.dart b/runtime/observatory/lib/src/elements/function_ref.dart
index e5ace692a41729483caa6b5a5534500da6a62117..c769fde9d721aa462808e7a2922b0edf6cd41f97 100644
--- a/runtime/observatory/lib/src/elements/function_ref.dart
+++ b/runtime/observatory/lib/src/elements/function_ref.dart
@@ -36,7 +36,6 @@ class FunctionRefElement extends HtmlElement implements Renderable {
factory FunctionRefElement(M.IsolateRef isolate, M.FunctionRef function,
{bool qualified: true, RenderingQueue queue}) {
- assert(isolate != null);
assert(function != null);
assert(qualified != null);
FunctionRefElement e = document.createElement(tag.name);
@@ -66,7 +65,7 @@ class FunctionRefElement extends HtmlElement implements Renderable {
void render() {
var content = <Element>[
new AnchorElement(
- href: M.isSyntheticFunction(_function.kind)
+ href: (M.isSyntheticFunction(_function.kind) || (_isolate == null))
? null
: Uris.inspect(_isolate, object: _function))
..text = _function.name
@@ -78,7 +77,7 @@ class FunctionRefElement extends HtmlElement implements Renderable {
content.addAll([
new SpanElement()..text = '.',
new AnchorElement(
- href: M.isSyntheticFunction(function.kind)
+ href: (M.isSyntheticFunction(function.kind) || (_isolate == null))
? null
: Uris.inspect(_isolate, object: function))
..text = function.name

Powered by Google App Engine
This is Rietveld 408576698