Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: runtime/observatory/lib/src/elements/class_ref.dart

Issue 2771293003: Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and st… (Closed)
Patch Set: Added page to Observatory to display native memory allocation information. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/class_ref.dart
diff --git a/runtime/observatory/lib/src/elements/class_ref.dart b/runtime/observatory/lib/src/elements/class_ref.dart
index 21bd6cce2f3798c4494584a9bfbca87c1f53c55f..1d0ae508ce9e675cfe84bf658841b9d9888a1a48 100644
--- a/runtime/observatory/lib/src/elements/class_ref.dart
+++ b/runtime/observatory/lib/src/elements/class_ref.dart
@@ -24,7 +24,6 @@ class ClassRefElement extends HtmlElement implements Renderable {
factory ClassRefElement(M.IsolateRef isolate, M.ClassRef cls,
{RenderingQueue queue}) {
- assert(isolate != null);
assert(cls != null);
ClassRefElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
@@ -50,8 +49,10 @@ class ClassRefElement extends HtmlElement implements Renderable {
void render() {
children = [
- new AnchorElement(href: Uris.inspect(_isolate, object: _class))
- ..text = _class.name
+ new AnchorElement(
+ href: (_isolate == null)
+ ? null
+ : Uris.inspect(_isolate, object: _class))..text = _class.name
];
}
}
« no previous file with comments | « runtime/observatory/lib/src/cpu_profile/cpu_profile.dart ('k') | runtime/observatory/lib/src/elements/code_ref.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698