chrome/browser/ui/webui/signin/inline_login_handler_impl.cc - Issue 2771233002: Remove the wrapper functions content::RecordAction et al

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 2771233002: Remove the wrapper functions content::RecordAction et al (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/signin/inline_login_handler.cc ('k') | chrome/browser/ui/webui/signin/signin_email_confirmation_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

index d992238736d54dc7b5a6f9b858fb2c8be69d0d74..c91cc2797ae46ea697eb62d8e8516b9bf2eebf24 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

@@ -14,6 +14,7 @@

#include "base/location.h"

#include "base/macros.h"

#include "base/metrics/histogram_macros.h"

+#include "base/metrics/user_metrics.h"

#include "base/metrics/user_metrics_action.h"

#include "base/single_thread_task_runner.h"

#include "base/strings/string_number_conversions.h"

@@ -63,7 +64,6 @@

#include "components/strings/grit/components_strings.h"

#include "content/public/browser/navigation_handle.h"

#include "content/public/browser/storage_partition.h"

-#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_ui.h"

#include "google_apis/gaia/gaia_auth_fetcher.h"

#include "google_apis/gaia/gaia_auth_util.h"

@@ -352,14 +352,14 @@ void InlineSigninHelper::ConfirmEmailAction(

Browser* browser = chrome::FindLastActiveWithProfile(profile_);

switch (action) {

case SigninEmailConfirmationDialog::CREATE_NEW_USER:

- content::RecordAction(

+ base::RecordAction(

base::UserMetricsAction("Signin_ImportDataPrompt_DontImport"));

CreateSyncStarter(browser, web_contents, current_url_, GURL(),

refresh_token, OneClickSigninSyncStarter::NEW_PROFILE,

start_mode, confirmation_required);

break;

case SigninEmailConfirmationDialog::START_SYNC:

- content::RecordAction(

+ base::RecordAction(

base::UserMetricsAction("Signin_ImportDataPrompt_ImportData"));

CreateSyncStarter(browser, web_contents, current_url_, GURL(),

refresh_token,

@@ -367,7 +367,7 @@ void InlineSigninHelper::ConfirmEmailAction(

confirmation_required);

break;

case SigninEmailConfirmationDialog::CLOSE:

- content::RecordAction(

+ base::RecordAction(

base::UserMetricsAction("Signin_ImportDataPrompt_Cancel"));

if (handler_) {

handler_->SyncStarterCallback(