chrome/browser/ui/webui/options/core_options_handler.cc - Issue 2771233002: Remove the wrapper functions content::RecordAction et al

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.cc

Issue 2771233002: Remove the wrapper functions content::RecordAction et al (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/content_settings_handler.cc ('k') | chrome/browser/ui/webui/options/language_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/core_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/core_options_handler.cc b/chrome/browser/ui/webui/options/core_options_handler.cc

index 4ab5062fa7ca71b7c0bf8889847e302db90aac1f..71ba099b3abd1d977c5ad06905060bfb23220540 100644

--- a/chrome/browser/ui/webui/options/core_options_handler.cc

+++ b/chrome/browser/ui/webui/options/core_options_handler.cc

@@ -12,6 +12,7 @@

#include "base/bind.h"

#include "base/bind_helpers.h"

#include "base/json/json_reader.h"

+#include "base/metrics/user_metrics.h"

#include "base/strings/string16.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/utf_string_conversions.h"

@@ -33,7 +34,6 @@

#include "components/url_formatter/url_fixer.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_types.h"

-#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_ui.h"

#include "extensions/browser/extension_pref_value_map.h"

#include "extensions/browser/extension_pref_value_map_factory.h"

@@ -322,7 +322,7 @@ void CoreOptionsHandler::ClearPref(const std::string& pref_name,

pref_service->ClearPref(pref_name);

if (!metric.empty())

- content::RecordComputedAction(metric);

+ base::RecordComputedAction(metric);

}

void CoreOptionsHandler::ProcessUserMetric(const base::Value* value,

@@ -337,7 +337,7 @@ void CoreOptionsHandler::ProcessUserMetric(const base::Value* value,

metric_string += bool_value ? "_Enable" : "_Disable";

}

- content::RecordComputedAction(metric_string);

+ base::RecordComputedAction(metric_string);

}

void CoreOptionsHandler::NotifyPrefChanged(

@@ -627,7 +627,7 @@ void CoreOptionsHandler::HandleClearPref(const base::ListValue* args) {

void CoreOptionsHandler::HandleUserMetricsAction(const base::ListValue* args) {

std::string metric = base::UTF16ToUTF8(ExtractStringValue(args));

if (!metric.empty())

- content::RecordComputedAction(metric);

+ base::RecordComputedAction(metric);

}

void CoreOptionsHandler::HandleDisableExtension(const base::ListValue* args) {