chrome/browser/ui/cocoa/tabs/tab_controller.mm - Issue 2771233002: Remove the wrapper functions content::RecordAction et al

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_controller.mm

Issue 2771233002: Remove the wrapper functions content::RecordAction et al (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tabs/tab_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_controller.mm

index ec6ca25d6c22845873572183cee2b2988a75ac54..0a9795adb1c83f9b18bc935545ac81cbbf3b91df 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_controller.mm

@@ -9,6 +9,7 @@

#include "base/i18n/rtl.h"

#include "base/mac/bundle_locations.h"

+#include "base/metrics/user_metrics.h"

#import "chrome/browser/themes/theme_properties.h"

#import "chrome/browser/themes/theme_service.h"

#include "chrome/browser/ui/cocoa/l10n_util.h"

@@ -17,7 +18,6 @@

#import "chrome/browser/ui/cocoa/tabs/tab_controller_target.h"

#import "chrome/browser/ui/cocoa/tabs/tab_view.h"

#import "chrome/browser/ui/cocoa/themed_window.h"

-#include "content/public/browser/user_metrics.h"

#import "extensions/common/extension.h"

#import "ui/base/cocoa/menu_controller.h"

#include "ui/base/material_design/material_design_controller.h"

@@ -200,15 +200,15 @@ static const CGFloat kTabElementYOrigin = 6;

if (alertIndicatorButton_ && ![alertIndicatorButton_ isHidden]) {

if ([alertIndicatorButton_ isEnabled]) {

- content::RecordAction(UserMetricsAction("CloseTab_MuteToggleAvailable"));

+ base::RecordAction(UserMetricsAction("CloseTab_MuteToggleAvailable"));

} else if ([alertIndicatorButton_ showingAlertState] ==

TabAlertState::AUDIO_PLAYING) {

- content::RecordAction(UserMetricsAction("CloseTab_AudioIndicator"));

+ base::RecordAction(UserMetricsAction("CloseTab_AudioIndicator"));

} else {

- content::RecordAction(UserMetricsAction("CloseTab_RecordingIndicator"));

+ base::RecordAction(UserMetricsAction("CloseTab_RecordingIndicator"));

}

} else {

- content::RecordAction(UserMetricsAction("CloseTab_NoAlertIndicator"));

+ base::RecordAction(UserMetricsAction("CloseTab_NoAlertIndicator"));

}

if ([[self target] respondsToSelector:@selector(closeTab:)]) {