chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 2771233002: Remove the wrapper functions content::RecordAction et al

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 2771233002: Remove the wrapper functions content::RecordAction et al (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_command_handler.mm ('k') | chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index a4d6598648122cd3103e42e14d68d8f07e844fce..ca3996dd9586c9eb7a8116dbecb4510df516c1ab 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -11,6 +11,7 @@

#include "base/i18n/rtl.h"

#include "base/macros.h"

#include "base/memory/ptr_util.h"

+#include "base/metrics/user_metrics.h"

#include "base/strings/sys_string_conversions.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/extensions/extension_action.h"

@@ -44,7 +45,6 @@

#include "components/bubble/bubble_ui.h"

#include "components/signin/core/browser/signin_metrics.h"

#include "content/public/browser/browser_thread.h"

-#include "content/public/browser/user_metrics.h"

#include "extensions/browser/install/extension_install_ui.h"

#include "extensions/common/extension.h"

#import "skia/ext/skia_utils_mac.h"

@@ -271,7 +271,7 @@ std::unique_ptr<BubbleUi> ExtensionInstalledBubble::BuildBubbleUi() {

[self updateAnchorPosition];

if (syncPromoController_) {

- content::RecordAction(base::UserMetricsAction(

+ base::RecordAction(base::UserMetricsAction(

"Signin_Impression_FromExtensionInstallBubble"));

}

[super showWindow:sender];