Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: chrome/browser/ui/browser.cc

Issue 2771233002: Remove the wrapper functions content::RecordAction et al (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 832153b86e17201770479a2f4bfa17284c823b52..3cad7e628f94076dd14d13101123af31b77a0b86 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -17,6 +17,7 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/metrics/histogram_macros.h"
+#include "base/metrics/user_metrics.h"
#include "base/process/process_info.h"
#include "base/profiler/scoped_tracker.h"
#include "base/single_thread_task_runner.h"
@@ -189,7 +190,6 @@
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/site_instance.h"
#include "content/public/browser/ssl_status.h"
-#include "content/public/browser/user_metrics.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_constants.h"
#include "content/public/common/content_switches.h"
@@ -394,7 +394,7 @@ Browser::Browser(const CreateParams& params)
// TODO(mlerman): After this hits stable channel, see if there are counts
// for this metric. If not, change the DCHECK above to a CHECK.
if (profile_->IsSystemProfile())
- content::RecordAction(base::UserMetricsAction("BrowserForSystemProfile"));
+ base::RecordAction(base::UserMetricsAction("BrowserForSystemProfile"));
// TODO(jeremy): Move to initializer list once flag is removed.
if (IsFastTabUnloadEnabled())
@@ -868,7 +868,7 @@ bool Browser::CanSupportWindowFeature(WindowFeature feature) const {
}
void Browser::OpenFile() {
- content::RecordAction(UserMetricsAction("OpenFile"));
+ base::RecordAction(UserMetricsAction("OpenFile"));
select_file_dialog_ = ui::SelectFileDialog::Create(
this, new ChromeSelectFilePolicy(
tab_strip_model_->GetActiveWebContents()));
@@ -1062,7 +1062,7 @@ void Browser::ActiveTabChanged(WebContents* old_contents,
new_view->SetBackgroundColor(old_view->background_color());
}
- content::RecordAction(UserMetricsAction("ActiveTabChanged"));
+ base::RecordAction(UserMetricsAction("ActiveTabChanged"));
// Update the bookmark state, since the BrowserWindow may query it during
// OnActiveTabChanged() below.
« no previous file with comments | « chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc ('k') | chrome/browser/ui/browser_command_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698