chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc - Issue 2771233002: Remove the wrapper functions content::RecordAction et al

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

Issue 2771233002: Remove the wrapper functions content::RecordAction et al (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_private_api.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

diff --git a/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc b/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

index 7025316c6d4a3ecc3a025731fda7df91705b3455..fb86a51bf50554dca4d487f4f5d9582b64ddad8d 100644

--- a/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

+++ b/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

@@ -12,6 +12,7 @@

#include "base/bind.h"

#include "base/command_line.h"

#include "base/metrics/histogram_macros.h"

+#include "base/metrics/user_metrics.h"

#include "base/metrics/user_metrics_action.h"

#include "base/strings/string16.h"

#include "chrome/browser/chromeos/login/lock/screen_locker.h"

@@ -20,7 +21,6 @@

#include "chrome/browser/ui/chrome_pages.h"

#include "chrome/common/url_constants.h"

#include "components/user_manager/user_manager.h"

-#include "content/public/browser/user_metrics.h"

#include "extensions/common/api/virtual_keyboard_private.h"

#include "media/audio/audio_system.h"

#include "ui/aura/window_tree_host.h"

@@ -163,7 +163,7 @@ bool ChromeVirtualKeyboardDelegate::SendKeyEvent(const std::string& type,

bool ChromeVirtualKeyboardDelegate::ShowLanguageSettings() {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

- content::RecordAction(base::UserMetricsAction("OpenLanguageOptionsDialog"));

+ base::RecordAction(base::UserMetricsAction("OpenLanguageOptionsDialog"));

chrome::ShowSettingsSubPageForProfile(ProfileManager::GetActiveUserProfile(),

chrome::kLanguageOptionsSubPage);

return true;