Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Side by Side Diff: chrome/browser/ui/webui/conflicts_ui.cc

Issue 2771233002: Remove the wrapper functions content::RecordAction et al (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/conflicts_ui.h" 5 #include "chrome/browser/ui/webui/conflicts_ui.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/bind_helpers.h" 12 #include "base/bind_helpers.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/memory/ptr_util.h" 14 #include "base/memory/ptr_util.h"
15 #include "base/memory/ref_counted_memory.h" 15 #include "base/memory/ref_counted_memory.h"
16 #include "base/metrics/user_metrics.h"
16 #include "base/scoped_observer.h" 17 #include "base/scoped_observer.h"
17 #include "base/strings/string_number_conversions.h" 18 #include "base/strings/string_number_conversions.h"
18 #include "base/strings/utf_string_conversions.h" 19 #include "base/strings/utf_string_conversions.h"
19 #include "base/values.h" 20 #include "base/values.h"
20 #include "build/build_config.h" 21 #include "build/build_config.h"
21 #include "chrome/browser/chrome_notification_types.h" 22 #include "chrome/browser/chrome_notification_types.h"
22 #include "chrome/browser/profiles/profile.h" 23 #include "chrome/browser/profiles/profile.h"
23 #include "chrome/browser/win/enumerate_modules_model.h" 24 #include "chrome/browser/win/enumerate_modules_model.h"
24 #include "chrome/common/url_constants.h" 25 #include "chrome/common/url_constants.h"
25 #include "chrome/grit/browser_resources.h" 26 #include "chrome/grit/browser_resources.h"
26 #include "chrome/grit/chromium_strings.h" 27 #include "chrome/grit/chromium_strings.h"
27 #include "chrome/grit/generated_resources.h" 28 #include "chrome/grit/generated_resources.h"
28 #include "chrome/grit/theme_resources.h" 29 #include "chrome/grit/theme_resources.h"
29 #include "components/strings/grit/components_strings.h" 30 #include "components/strings/grit/components_strings.h"
30 #include "content/public/browser/notification_observer.h" 31 #include "content/public/browser/notification_observer.h"
31 #include "content/public/browser/notification_registrar.h" 32 #include "content/public/browser/notification_registrar.h"
32 #include "content/public/browser/notification_service.h" 33 #include "content/public/browser/notification_service.h"
33 #include "content/public/browser/user_metrics.h"
34 #include "content/public/browser/web_contents.h" 34 #include "content/public/browser/web_contents.h"
35 #include "content/public/browser/web_ui.h" 35 #include "content/public/browser/web_ui.h"
36 #include "content/public/browser/web_ui_data_source.h" 36 #include "content/public/browser/web_ui_data_source.h"
37 #include "content/public/browser/web_ui_message_handler.h" 37 #include "content/public/browser/web_ui_message_handler.h"
38 #include "ui/base/l10n/l10n_util.h" 38 #include "ui/base/l10n/l10n_util.h"
39 #include "ui/base/layout.h" 39 #include "ui/base/layout.h"
40 #include "ui/base/resource/resource_bundle.h" 40 #include "ui/base/resource/resource_bundle.h"
41 41
42 using base::UserMetricsAction; 42 using base::UserMetricsAction;
43 using content::WebContents; 43 using content::WebContents;
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 163
164 } // namespace 164 } // namespace
165 165
166 /////////////////////////////////////////////////////////////////////////////// 166 ///////////////////////////////////////////////////////////////////////////////
167 // 167 //
168 // ConflictsUI 168 // ConflictsUI
169 // 169 //
170 /////////////////////////////////////////////////////////////////////////////// 170 ///////////////////////////////////////////////////////////////////////////////
171 171
172 ConflictsUI::ConflictsUI(content::WebUI* web_ui) : WebUIController(web_ui) { 172 ConflictsUI::ConflictsUI(content::WebUI* web_ui) : WebUIController(web_ui) {
173 content::RecordAction(UserMetricsAction("ViewAboutConflicts")); 173 base::RecordAction(UserMetricsAction("ViewAboutConflicts"));
174 web_ui->AddMessageHandler(base::MakeUnique<ConflictsDOMHandler>()); 174 web_ui->AddMessageHandler(base::MakeUnique<ConflictsDOMHandler>());
175 175
176 // Set up the about:conflicts source. 176 // Set up the about:conflicts source.
177 Profile* profile = Profile::FromWebUI(web_ui); 177 Profile* profile = Profile::FromWebUI(web_ui);
178 content::WebUIDataSource::Add(profile, CreateConflictsUIHTMLSource()); 178 content::WebUIDataSource::Add(profile, CreateConflictsUIHTMLSource());
179 } 179 }
180 180
181 // static 181 // static
182 base::RefCountedMemory* ConflictsUI::GetFaviconResourceBytes( 182 base::RefCountedMemory* ConflictsUI::GetFaviconResourceBytes(
183 ui::ScaleFactor scale_factor) { 183 ui::ScaleFactor scale_factor) {
184 return static_cast<base::RefCountedMemory*>( 184 return static_cast<base::RefCountedMemory*>(
185 ResourceBundle::GetSharedInstance().LoadDataResourceBytesForScale( 185 ResourceBundle::GetSharedInstance().LoadDataResourceBytesForScale(
186 IDR_CONFLICT_FAVICON, scale_factor)); 186 IDR_CONFLICT_FAVICON, scale_factor));
187 } 187 }
188 188
189 #endif 189 #endif
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/app_launcher_login_handler.cc ('k') | chrome/browser/ui/webui/flash_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698