Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/browser/ui/browser_command_controller.cc

Issue 2771233002: Remove the wrapper functions content::RecordAction et al (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_command_controller.h" 5 #include "chrome/browser/ui/browser_command_controller.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/debug/debugging_flags.h" 12 #include "base/debug/debugging_flags.h"
13 #include "base/debug/profiler.h" 13 #include "base/debug/profiler.h"
14 #include "base/feature_list.h" 14 #include "base/feature_list.h"
15 #include "base/macros.h" 15 #include "base/macros.h"
16 #include "base/metrics/user_metrics.h"
16 #include "build/build_config.h" 17 #include "build/build_config.h"
17 #include "chrome/app/chrome_command_ids.h" 18 #include "chrome/app/chrome_command_ids.h"
18 #include "chrome/browser/browser_process.h" 19 #include "chrome/browser/browser_process.h"
19 #include "chrome/browser/chrome_notification_types.h" 20 #include "chrome/browser/chrome_notification_types.h"
20 #include "chrome/browser/defaults.h" 21 #include "chrome/browser/defaults.h"
21 #include "chrome/browser/extensions/extension_service.h" 22 #include "chrome/browser/extensions/extension_service.h"
22 #include "chrome/browser/extensions/extension_util.h" 23 #include "chrome/browser/extensions/extension_util.h"
23 #include "chrome/browser/lifetime/application_lifetime.h" 24 #include "chrome/browser/lifetime/application_lifetime.h"
24 #include "chrome/browser/prefs/incognito_mode_prefs.h" 25 #include "chrome/browser/prefs/incognito_mode_prefs.h"
25 #include "chrome/browser/profiles/profile.h" 26 #include "chrome/browser/profiles/profile.h"
(...skipping 16 matching lines...) Expand all
42 #include "chrome/common/profiling.h" 43 #include "chrome/common/profiling.h"
43 #include "components/bookmarks/common/bookmark_pref_names.h" 44 #include "components/bookmarks/common/bookmark_pref_names.h"
44 #include "components/browser_sync/profile_sync_service.h" 45 #include "components/browser_sync/profile_sync_service.h"
45 #include "components/dom_distiller/core/dom_distiller_switches.h" 46 #include "components/dom_distiller/core/dom_distiller_switches.h"
46 #include "components/prefs/pref_service.h" 47 #include "components/prefs/pref_service.h"
47 #include "components/sessions/core/tab_restore_service.h" 48 #include "components/sessions/core/tab_restore_service.h"
48 #include "components/signin/core/common/signin_pref_names.h" 49 #include "components/signin/core/common/signin_pref_names.h"
49 #include "content/public/browser/native_web_keyboard_event.h" 50 #include "content/public/browser/native_web_keyboard_event.h"
50 #include "content/public/browser/navigation_controller.h" 51 #include "content/public/browser/navigation_controller.h"
51 #include "content/public/browser/navigation_entry.h" 52 #include "content/public/browser/navigation_entry.h"
52 #include "content/public/browser/user_metrics.h"
53 #include "content/public/browser/web_contents.h" 53 #include "content/public/browser/web_contents.h"
54 #include "content/public/browser/web_contents_observer.h" 54 #include "content/public/browser/web_contents_observer.h"
55 #include "content/public/common/service_manager_connection.h" 55 #include "content/public/common/service_manager_connection.h"
56 #include "content/public/common/url_constants.h" 56 #include "content/public/common/url_constants.h"
57 #include "extensions/browser/extension_system.h" 57 #include "extensions/browser/extension_system.h"
58 #include "mash/public/interfaces/launchable.mojom.h" 58 #include "mash/public/interfaces/launchable.mojom.h"
59 #include "printing/features/features.h" 59 #include "printing/features/features.h"
60 #include "services/service_manager/public/cpp/connector.h" 60 #include "services/service_manager/public/cpp/connector.h"
61 #include "ui/events/keycodes/keyboard_codes.h" 61 #include "ui/events/keycodes/keyboard_codes.h"
62 62
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 break; 328 break;
329 329
330 // Window management commands 330 // Window management commands
331 case IDC_NEW_WINDOW: 331 case IDC_NEW_WINDOW:
332 NewWindow(browser_); 332 NewWindow(browser_);
333 break; 333 break;
334 case IDC_NEW_INCOGNITO_WINDOW: 334 case IDC_NEW_INCOGNITO_WINDOW:
335 NewIncognitoWindow(browser_); 335 NewIncognitoWindow(browser_);
336 break; 336 break;
337 case IDC_CLOSE_WINDOW: 337 case IDC_CLOSE_WINDOW:
338 content::RecordAction(base::UserMetricsAction("CloseWindowByKey")); 338 base::RecordAction(base::UserMetricsAction("CloseWindowByKey"));
339 CloseWindow(browser_); 339 CloseWindow(browser_);
340 break; 340 break;
341 case IDC_NEW_TAB: 341 case IDC_NEW_TAB:
342 NewTab(browser_); 342 NewTab(browser_);
343 break; 343 break;
344 case IDC_CLOSE_TAB: 344 case IDC_CLOSE_TAB:
345 content::RecordAction(base::UserMetricsAction("CloseTabByKey")); 345 base::RecordAction(base::UserMetricsAction("CloseTabByKey"));
346 CloseTab(browser_); 346 CloseTab(browser_);
347 break; 347 break;
348 case IDC_SELECT_NEXT_TAB: 348 case IDC_SELECT_NEXT_TAB:
349 content::RecordAction(base::UserMetricsAction("Accel_SelectNextTab")); 349 base::RecordAction(base::UserMetricsAction("Accel_SelectNextTab"));
350 SelectNextTab(browser_); 350 SelectNextTab(browser_);
351 break; 351 break;
352 case IDC_SELECT_PREVIOUS_TAB: 352 case IDC_SELECT_PREVIOUS_TAB:
353 content::RecordAction( 353 base::RecordAction(base::UserMetricsAction("Accel_SelectPreviousTab"));
354 base::UserMetricsAction("Accel_SelectPreviousTab"));
355 SelectPreviousTab(browser_); 354 SelectPreviousTab(browser_);
356 break; 355 break;
357 case IDC_MOVE_TAB_NEXT: 356 case IDC_MOVE_TAB_NEXT:
358 MoveTabNext(browser_); 357 MoveTabNext(browser_);
359 break; 358 break;
360 case IDC_MOVE_TAB_PREVIOUS: 359 case IDC_MOVE_TAB_PREVIOUS:
361 MoveTabPrevious(browser_); 360 MoveTabPrevious(browser_);
362 break; 361 break;
363 case IDC_SELECT_TAB_0: 362 case IDC_SELECT_TAB_0:
364 case IDC_SELECT_TAB_1: 363 case IDC_SELECT_TAB_1:
365 case IDC_SELECT_TAB_2: 364 case IDC_SELECT_TAB_2:
366 case IDC_SELECT_TAB_3: 365 case IDC_SELECT_TAB_3:
367 case IDC_SELECT_TAB_4: 366 case IDC_SELECT_TAB_4:
368 case IDC_SELECT_TAB_5: 367 case IDC_SELECT_TAB_5:
369 case IDC_SELECT_TAB_6: 368 case IDC_SELECT_TAB_6:
370 case IDC_SELECT_TAB_7: 369 case IDC_SELECT_TAB_7:
371 content::RecordAction(base::UserMetricsAction("Accel_SelectNumberedTab")); 370 base::RecordAction(base::UserMetricsAction("Accel_SelectNumberedTab"));
372 SelectNumberedTab(browser_, id - IDC_SELECT_TAB_0); 371 SelectNumberedTab(browser_, id - IDC_SELECT_TAB_0);
373 break; 372 break;
374 case IDC_SELECT_LAST_TAB: 373 case IDC_SELECT_LAST_TAB:
375 content::RecordAction(base::UserMetricsAction("Accel_SelectNumberedTab")); 374 base::RecordAction(base::UserMetricsAction("Accel_SelectNumberedTab"));
376 SelectLastTab(browser_); 375 SelectLastTab(browser_);
377 break; 376 break;
378 case IDC_DUPLICATE_TAB: 377 case IDC_DUPLICATE_TAB:
379 DuplicateTab(browser_); 378 DuplicateTab(browser_);
380 break; 379 break;
381 case IDC_RESTORE_TAB: 380 case IDC_RESTORE_TAB:
382 RestoreTab(browser_); 381 RestoreTab(browser_);
383 break; 382 break;
384 case IDC_SHOW_AS_TAB: 383 case IDC_SHOW_AS_TAB:
385 ConvertPopupToTabbedBrowser(browser_); 384 ConvertPopupToTabbedBrowser(browser_);
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 break; 427 break;
429 case IDC_EMAIL_PAGE_LOCATION: 428 case IDC_EMAIL_PAGE_LOCATION:
430 EmailPageLocation(browser_); 429 EmailPageLocation(browser_);
431 break; 430 break;
432 case IDC_PRINT: 431 case IDC_PRINT:
433 Print(browser_); 432 Print(browser_);
434 break; 433 break;
435 434
436 #if BUILDFLAG(ENABLE_BASIC_PRINTING) 435 #if BUILDFLAG(ENABLE_BASIC_PRINTING)
437 case IDC_BASIC_PRINT: 436 case IDC_BASIC_PRINT:
438 content::RecordAction(base::UserMetricsAction("Accel_Advanced_Print")); 437 base::RecordAction(base::UserMetricsAction("Accel_Advanced_Print"));
439 BasicPrint(browser_); 438 BasicPrint(browser_);
440 break; 439 break;
441 #endif // ENABLE_BASIC_PRINTING 440 #endif // ENABLE_BASIC_PRINTING
442 441
443 case IDC_SAVE_CREDIT_CARD_FOR_PAGE: 442 case IDC_SAVE_CREDIT_CARD_FOR_PAGE:
444 SaveCreditCard(browser_); 443 SaveCreditCard(browser_);
445 break; 444 break;
446 case IDC_TRANSLATE_PAGE: 445 case IDC_TRANSLATE_PAGE:
447 Translate(browser_); 446 Translate(browser_);
448 break; 447 break;
(...skipping 25 matching lines...) Expand all
474 break; 473 break;
475 case IDC_ZOOM_NORMAL: 474 case IDC_ZOOM_NORMAL:
476 Zoom(browser_, content::PAGE_ZOOM_RESET); 475 Zoom(browser_, content::PAGE_ZOOM_RESET);
477 break; 476 break;
478 case IDC_ZOOM_MINUS: 477 case IDC_ZOOM_MINUS:
479 Zoom(browser_, content::PAGE_ZOOM_OUT); 478 Zoom(browser_, content::PAGE_ZOOM_OUT);
480 break; 479 break;
481 480
482 // Focus various bits of UI 481 // Focus various bits of UI
483 case IDC_FOCUS_TOOLBAR: 482 case IDC_FOCUS_TOOLBAR:
484 content::RecordAction(base::UserMetricsAction("Accel_Focus_Toolbar")); 483 base::RecordAction(base::UserMetricsAction("Accel_Focus_Toolbar"));
485 FocusToolbar(browser_); 484 FocusToolbar(browser_);
486 break; 485 break;
487 case IDC_FOCUS_LOCATION: 486 case IDC_FOCUS_LOCATION:
488 content::RecordAction(base::UserMetricsAction("Accel_Focus_Location")); 487 base::RecordAction(base::UserMetricsAction("Accel_Focus_Location"));
489 FocusLocationBar(browser_); 488 FocusLocationBar(browser_);
490 break; 489 break;
491 case IDC_FOCUS_SEARCH: 490 case IDC_FOCUS_SEARCH:
492 content::RecordAction(base::UserMetricsAction("Accel_Focus_Search")); 491 base::RecordAction(base::UserMetricsAction("Accel_Focus_Search"));
493 FocusSearch(browser_); 492 FocusSearch(browser_);
494 break; 493 break;
495 case IDC_FOCUS_MENU_BAR: 494 case IDC_FOCUS_MENU_BAR:
496 FocusAppMenu(browser_); 495 FocusAppMenu(browser_);
497 break; 496 break;
498 case IDC_FOCUS_BOOKMARKS: 497 case IDC_FOCUS_BOOKMARKS:
499 content::RecordAction( 498 base::RecordAction(base::UserMetricsAction("Accel_Focus_Bookmarks"));
500 base::UserMetricsAction("Accel_Focus_Bookmarks"));
501 FocusBookmarksToolbar(browser_); 499 FocusBookmarksToolbar(browser_);
502 break; 500 break;
503 case IDC_FOCUS_INFOBARS: 501 case IDC_FOCUS_INFOBARS:
504 FocusInfobars(browser_); 502 FocusInfobars(browser_);
505 break; 503 break;
506 case IDC_FOCUS_NEXT_PANE: 504 case IDC_FOCUS_NEXT_PANE:
507 FocusNextPane(browser_); 505 FocusNextPane(browser_);
508 break; 506 break;
509 case IDC_FOCUS_PREVIOUS_PANE: 507 case IDC_FOCUS_PREVIOUS_PANE:
510 FocusPreviousPane(browser_); 508 FocusPreviousPane(browser_);
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
552 ToggleBookmarkBar(browser_); 550 ToggleBookmarkBar(browser_);
553 break; 551 break;
554 case IDC_PROFILING_ENABLED: 552 case IDC_PROFILING_ENABLED:
555 Profiling::Toggle(); 553 Profiling::Toggle();
556 break; 554 break;
557 555
558 case IDC_SHOW_BOOKMARK_MANAGER: 556 case IDC_SHOW_BOOKMARK_MANAGER:
559 ShowBookmarkManager(browser_); 557 ShowBookmarkManager(browser_);
560 break; 558 break;
561 case IDC_SHOW_APP_MENU: 559 case IDC_SHOW_APP_MENU:
562 content::RecordAction(base::UserMetricsAction("Accel_Show_App_Menu")); 560 base::RecordAction(base::UserMetricsAction("Accel_Show_App_Menu"));
563 ShowAppMenu(browser_); 561 ShowAppMenu(browser_);
564 break; 562 break;
565 case IDC_SHOW_AVATAR_MENU: 563 case IDC_SHOW_AVATAR_MENU:
566 ShowAvatarMenu(browser_); 564 ShowAvatarMenu(browser_);
567 break; 565 break;
568 case IDC_SHOW_HISTORY: 566 case IDC_SHOW_HISTORY:
569 ShowHistory(browser_); 567 ShowHistory(browser_);
570 break; 568 break;
571 case IDC_SHOW_DOWNLOADS: 569 case IDC_SHOW_DOWNLOADS:
572 ShowDownloads(browser_); 570 ShowDownloads(browser_);
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
1144 1142
1145 BrowserWindow* BrowserCommandController::window() { 1143 BrowserWindow* BrowserCommandController::window() {
1146 return browser_->window(); 1144 return browser_->window();
1147 } 1145 }
1148 1146
1149 Profile* BrowserCommandController::profile() { 1147 Profile* BrowserCommandController::profile() {
1150 return browser_->profile(); 1148 return browser_->profile();
1151 } 1149 }
1152 1150
1153 } // namespace chrome 1151 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698