Rename AudioRenderer::Play/Pause() to Start/StopRendering().

Rename AudioRenderer::Play/Pause() to Start/StopRendering().

This makes a clearer separation between methods for controlling the
actual rendering of audio versus methods for controlling the state of the
renderer (i.e,. flushing and seeking).

Consequently, clean up AudioRendererImpl to reflect the separation
between rendering methods and state change methods.

BUG=370634
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270017

[DaleCurtis, 2014-05-12 18:25:33]

lgtm

[xhwang1, 2014-05-12 18:48:55]

drive-by question...

https://codereview.chromium.org/277123002/diff/70001/media/filters/audio_rend...
File media/filters/audio_renderer_impl.h (right):

https://codereview.chromium.org/277123002/diff/70001/media/filters/audio_rend...
media/filters/audio_renderer_impl.h:128: kPlaying,
nit: now what does kPlaying exactly mean?

[scherkus (not reviewing), 2014-05-12 18:55:32]

https://codereview.chromium.org/277123002/diff/70001/media/filters/audio_rend...
File media/filters/audio_renderer_impl.h (right):

https://codereview.chromium.org/277123002/diff/70001/media/filters/audio_rend...
media/filters/audio_renderer_impl.h:128: kPlaying,
On 2014/05/12 18:48:56, Xiaohan Wang wrote:
> nit: now what does kPlaying exactly mean?

see the comment I added above -- unless your nit is that you feel the comment
doesn't explain what kPlaying is :)

the model we're moving towards is that we're always in a playing state, but that
it requires the clock to be advancing (i.e., by starting/stopping rendering of
audio)

[scherkus (not reviewing), 2014-05-12 21:21:00]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-05-12 21:23:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scherkus@chromium.org/277123002/90001

[commit-bot: I haz the power, 2014-05-13 00:44:29]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-13 05:00:27]

Change committed as 270017

[vabr (Chromium), 2014-05-13 06:51:20]

A revert of this CL has been created in
https://codereview.chromium.org/274443006/ by vabr@chromium.org.

The reason for reverting is: This seems to have broken
NewFrameProcessor/PipelineIntegrationTest.ChunkDemuxerAbortRead_AudioOnly/0
Linux Tests (dbg)(2) and Win7 Tests (dbg)(1).
Will provide links and stdio on the new CL. This is speculative, if the issue
won't go away, the revert will be reverted..