src/wasm/wasm-module.cc - Issue 2771183002: [wasm][asm.js] Fix and enable several asm.js tests with the new parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-module.cc

Issue 2771183002: [wasm][asm.js] Fix and enable several asm.js tests with the new parser. (Closed)

Patch Set: fix one more item Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-module.cc

diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc

index d1f07608259fa5d5423d439a9888fb77a4fcb00c..b150ffbf15479033519061662c50926ce43eb426 100644

--- a/src/wasm/wasm-module.cc

+++ b/src/wasm/wasm-module.cc

@@ -1833,7 +1833,7 @@ class InstantiationHelper {

module_name, import_name);

return -1;

}

- if (FLAG_fast_validate_asm) {

+ if (module_->is_asm_js() && FLAG_fast_validate_asm) {

if (module_->globals[import.index].type == kWasmI32) {

value = Object::ToInt32(isolate_, value).ToHandleChecked();

} else {

« no previous file with comments | « src/asmjs/asm-scanner.cc ('k') | src/wasm/wasm-module-builder.cc » ('j') | no next file with comments »