Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: src/wasm/wasm-module-builder.cc

Issue 2771183002: [wasm][asm.js] Fix and enable several asm.js tests with the new parser. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/asmjs/asm-scanner.cc ('k') | test/mjsunit/asm/regress-641885.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module-builder.cc
diff --git a/src/wasm/wasm-module-builder.cc b/src/wasm/wasm-module-builder.cc
index b1b859ba42cbd9c0d63b2c0950869760a7f8b42b..548c2d0b672ed8581e4e0d0b0795e52fe0406d0f 100644
--- a/src/wasm/wasm-module-builder.cc
+++ b/src/wasm/wasm-module-builder.cc
@@ -191,6 +191,10 @@ void WasmFunctionBuilder::StashCode(std::vector<byte>* dst, size_t position) {
return;
}
size_t len = body_.size() - position;
+ if (len == 0) {
+ // TODO(bradnelson): Figure out why the memcpy crashes if len == 0.
Michael Starzinger 2017/03/24 11:56:05 It is not the memcpy that crashes but the accessor
bradnelson 2017/03/28 04:34:31 Done.
+ return;
+ }
dst->resize(len);
memcpy(dst->data(), &body_[position], len);
body_.resize(position);
« no previous file with comments | « src/asmjs/asm-scanner.cc ('k') | test/mjsunit/asm/regress-641885.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698