runtime/vm/redundancy_elimination.cc - Issue 2771013002: Add more safe points in compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/redundancy_elimination.cc

Issue 2771013002: Add more safe points in compiler (Closed)

Patch Set: Fix test that 'parses' verbose GC output Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/redundancy_elimination.cc

diff --git a/runtime/vm/redundancy_elimination.cc b/runtime/vm/redundancy_elimination.cc

index 66a287cc15db1536fa15ee8595f93d5c31753d1d..1cabf787c2e9ed2396cf6c04c17a51b6364d1c99 100644

--- a/runtime/vm/redundancy_elimination.cc

+++ b/runtime/vm/redundancy_elimination.cc

@@ -2402,6 +2402,9 @@ bool DominatorBasedCSE::OptimizeRecursive(FlowGraph* graph,

// Process children in the dominator tree recursively.

intptr_t num_children = block->dominated_blocks().length();

+ if (num_children != 0) {

+ graph->thread()->CheckForSafepoint();

+ }

for (intptr_t i = 0; i < num_children; ++i) {

BlockEntryInstr* child = block->dominated_blocks()[i];

if (i < num_children - 1) {

« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/scavenger.h » ('j') | no next file with comments »