Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: runtime/tools/verbose_gc_to_bmu.dart

Issue 2771013002: Add more safe points in compiler (Closed)
Patch Set: Fix test that 'parses' verbose GC output Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/compiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/tools/verbose_gc_to_bmu.dart
diff --git a/runtime/tools/verbose_gc_to_bmu.dart b/runtime/tools/verbose_gc_to_bmu.dart
index 20030fa3a4aa018a72b0a1d377a6e1f1f4e851f7..fa4d255c48ec40339cfae12f0dbe0c4667fb5cfe 100644
--- a/runtime/tools/verbose_gc_to_bmu.dart
+++ b/runtime/tools/verbose_gc_to_bmu.dart
@@ -78,9 +78,11 @@ class Timeline {
Interval<int> parseVerboseGCLine(String line) {
var fields = line.split(',');
// Update this (and indices below, if needed) when logging format changes.
- if (fields.length != 25) {
- assert(line.startsWith('[ GC | space | count | start | gc time') ||
- line.startsWith('[ (isolate)| (reason)| | (s) | (ms) '));
+ if (fields.length < 10) {
+ // Ignore the lines that just specify column names, separated by '|'.
+ // We assume these have very few commas in them, so that fields.length
+ // is < 10.
+ assert(line.contains("|"));
return new Interval<int>(0, 0);
}
var begin = (1e6 * double.parse(fields[2])).floor();
« no previous file with comments | « no previous file | runtime/vm/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698