Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: runtime/vm/flow_graph.cc

Issue 2771013002: Add more safe points in compiler (Closed)
Patch Set: Fix logic error in compiler code installation, more safe points, remove safe point in zone code, ni… Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph.cc
diff --git a/runtime/vm/flow_graph.cc b/runtime/vm/flow_graph.cc
index c14c18e5e792fec7e25013d395e9060d5b07aab3..b69c1af20e988099bcf50abba769cdc2743586bf 100644
--- a/runtime/vm/flow_graph.cc
+++ b/runtime/vm/flow_graph.cc
@@ -1316,6 +1316,7 @@ void FlowGraph::RemoveRedefinitions() {
// Remove redefinition instructions inserted to inhibit hoisting.
for (BlockIterator block_it = reverse_postorder_iterator(); !block_it.Done();
block_it.Advance()) {
+ thread()->CheckForSafepoint();
Vyacheslav Egorov (Google) 2017/03/27 14:11:51 It seems strange to have a safepoint-per-block onl
erikcorry 2017/03/30 14:10:19 I just picked the ones that showed up as slow for
for (ForwardInstructionIterator instr_it(block_it.Current());
!instr_it.Done(); instr_it.Advance()) {
RedefinitionInstr* redefinition = instr_it.Current()->AsRedefinition();

Powered by Google App Engine
This is Rietveld 408576698