Add more safe points in compiler

runtime/vm/heap.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/heap.h"
 
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/flags.h"
 #include "vm/isolate.h"
@@ skipping 682 matching lines @@
 
 void Heap::RecordBeforeGC(Space space, GCReason reason) {
   ASSERT((space == kNew && gc_new_space_in_progress_) ||
          (space == kOld && gc_old_space_in_progress_));
   stats_.num_++;
   stats_.space_ = space;
   stats_.reason_ = reason;
   stats_.before_.micros_ = OS::GetCurrentMonotonicMicros();
   stats_.before_.new_ = new_space_.GetCurrentUsage();
   stats_.before_.old_ = old_space_.GetCurrentUsage();
-  stats_.times_[0] = 0;
-  stats_.times_[1] = 0;
-  stats_.times_[2] = 0;
-  stats_.times_[3] = 0;
-  stats_.data_[0] = 0;
-  stats_.data_[1] = 0;
-  stats_.data_[2] = 0;
-  stats_.data_[3] = 0;
+  for (int i = 0; i < GCStats::kTimeEntries; i++)
+    stats_.times_[i] = 0;
+  for (int i = 0; i < GCStats::kDataEntries; i++)
+    stats_.data_[i] = 0;
 }
 
 
 void Heap::RecordAfterGC(Space space) {
   stats_.after_.micros_ = OS::GetCurrentMonotonicMicros();
   int64_t delta = stats_.after_.micros_ - stats_.before_.micros_;
   if (stats_.space_ == kNew) {
     new_space_.AddGCTime(delta);
     new_space_.IncrementCollections();
   } else {
@@ skipping 14 matching lines @@
 #endif  // !PRODUCT
 }
 
 
 void Heap::PrintStats() {
   if (!FLAG_verbose_gc) return;
 
   if ((FLAG_verbose_gc_hdr != 0) &&
       (((stats_.num_ - 1) % FLAG_verbose_gc_hdr) == 0)) {
     OS::PrintErr(
-        "[    GC    |  space  | count | start | gc time | "
-        "new gen (KB) | old gen (KB) | timers | data ]\n"
-        "[ (isolate)| (reason)|       |  (s)  |   (ms)  | "
-        "used,cap,ext | used,cap,ext |  (ms)  |      ]\n");
+        "[              |                      |     |       |      "
+        "| new gen     | new gen     | new gen "
+        "| old gen       | old gen       | old gen     "
+        "| sweep | safe- | roots/| stbuf/| tospc/| weaks/|               ]\n"
+        "[ GC isolate   | space (reason)       | GC# | start | time "
+        "| used (kB)   | capacity kB | external"
+        "| used (kB)     | capacity (kB) | external kB "
+        "| thread| point |marking| reset | sweep |swplrge| data          ]\n"
+        "[              |                      |     |  (s)  | (ms) "
+        "|before| after|before| after| b4 |aftr"
+        "| before| after | before| after |before| after"
+        "| (ms)  | (ms)  | (ms)  | (ms)  | (ms)  | (ms)  |               ]\n");
   }
 
   // clang-format off
   const char* space_str = stats_.space_ == kNew ? "Scavenge" : "Mark-Sweep";
   OS::PrintErr(
-    "[ GC(%" Pd64 "): %s(%s), "  // GC(isolate), space(reason)
-    "%" Pd ", "  // count
-    "%.3f, "  // start time
-    "%.3f, "  // total time
-    "%" Pd ", %" Pd ", "  // new gen: in use before/after
-    "%" Pd ", %" Pd ", "  // new gen: capacity before/after
-    "%" Pd ", %" Pd ", "  // new gen: external before/after
-    "%" Pd ", %" Pd ", "  // old gen: in use before/after
-    "%" Pd ", %" Pd ", "  // old gen: capacity before/after
-    "%" Pd ", %" Pd ", "  // old gen: external before/after
-    "%.3f, %.3f, %.3f, %.3f, "  // times
+    "[ GC %9" Pd64 " : %10s(%9s), "  // GC(isolate), space(reason)
+    "%4" Pd ", "  // count
+    "%6.2f, "  // start time
+    "%5.1f, "  // total time
+    "%5" Pd ", %5" Pd ", "  // new gen: in use before/after
+    "%5" Pd ", %5" Pd ", "  // new gen: capacity before/after
+    "%3" Pd ", %3" Pd ", "  // new gen: external before/after
+    "%6" Pd ", %6" Pd ", "  // old gen: in use before/after
+    "%6" Pd ", %6" Pd ", "  // old gen: capacity before/after
+    "%5" Pd ", %5" Pd ", "  // old gen: external before/after
+    "%6.2f, %6.2f, %6.2f, %6.2f, %6.2f, %6.2f, "  // times
     "%" Pd ", %" Pd ", %" Pd ", %" Pd ", "  // data
     "]\n",  // End with a comma to make it easier to import in spreadsheets.
     isolate()->main_port(), space_str, GCReasonToString(stats_.reason_),
     stats_.num_,
     MicrosecondsToSeconds(isolate()->UptimeMicros()),
     MicrosecondsToMilliseconds(stats_.after_.micros_ -
                                     stats_.before_.micros_),
     RoundWordsToKB(stats_.before_.new_.used_in_words),
     RoundWordsToKB(stats_.after_.new_.used_in_words),
     RoundWordsToKB(stats_.before_.new_.capacity_in_words),
     RoundWordsToKB(stats_.after_.new_.capacity_in_words),
     RoundWordsToKB(stats_.before_.new_.external_in_words),
     RoundWordsToKB(stats_.after_.new_.external_in_words),
     RoundWordsToKB(stats_.before_.old_.used_in_words),
     RoundWordsToKB(stats_.after_.old_.used_in_words),
     RoundWordsToKB(stats_.before_.old_.capacity_in_words),
     RoundWordsToKB(stats_.after_.old_.capacity_in_words),
     RoundWordsToKB(stats_.before_.old_.external_in_words),
     RoundWordsToKB(stats_.after_.old_.external_in_words),
     MicrosecondsToMilliseconds(stats_.times_[0]),
     MicrosecondsToMilliseconds(stats_.times_[1]),
     MicrosecondsToMilliseconds(stats_.times_[2]),
     MicrosecondsToMilliseconds(stats_.times_[3]),
+    MicrosecondsToMilliseconds(stats_.times_[4]),
+    MicrosecondsToMilliseconds(stats_.times_[5]),
     stats_.data_[0],
     stats_.data_[1],
     stats_.data_[2],
     stats_.data_[3]);
   // clang-format on
 }
 
 
 void Heap::PrintStatsToTimeline(TimelineEventScope* event) {
 #if !defined(PRODUCT)
@@ skipping 50 matching lines @@
   Dart::vm_isolate()->heap()->WriteProtect(false);
 }
 
 
 WritableVMIsolateScope::~WritableVMIsolateScope() {
   ASSERT(Dart::vm_isolate()->heap()->UsedInWords(Heap::kNew) == 0);
   Dart::vm_isolate()->heap()->WriteProtect(true);
 }
 
 }  // namespace dart