Issue 2770943006: retry of that the PlzNavigate code path removes pending NavigationEntrys if the navigation is cancel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2770943006: retry of that the PlzNavigate code path removes pending NavigationEntrys if the navigation is cancel (Closed)

Created:
3 years, 9 months ago by jam

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

test patch from issue 2768933004 at patchset 1 (http://crrev.com/2768933004#ps1) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -4 lines)			Patch
M	content/browser/frame_host/frame_tree_node.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl_browsertest.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	content/public/common/browser_side_navigation_policy.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jam

Description was changed from ========== test patch from issue 2768933004 at patchset 1 (http://crrev.com/2768933004#ps1) ========== ...

3 years, 9 months ago (2017-03-24 16:11:21 UTC) #1

jam

The CQ bit was checked by jam@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-24 16:11:29 UTC) #2

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770943006/1

3 years, 9 months ago (2017-03-24 16:12:09 UTC) #3

jam

3 years, 9 months ago (2017-03-24 16:53:59 UTC) #5

Description was changed from

==========
test
patch from issue 2768933004 at patchset 1 (http://crrev.com/2768933004#ps1)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
test
patch from issue 2768933004 at patchset 1 (http://crrev.com/2768933004#ps1)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages