Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 277093003: Move bookmark_utils_unittest.cc into components/bookmarks. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
sky, blundell
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Move bookmark_utils_unittest.cc into components/bookmarks. This test driver has no dependencies on chrome anymore so we can move it straightforward into components_unittests target (from unit_test). BUG=367837 TEST=components_unittests --gtest_filter=BookmarkUtils* R=blundell@chromium.org, sky@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269801

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -390 lines) Patch
D chrome/browser/bookmarks/bookmark_utils_unittest.cc View 1 chunk +0 lines, -390 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A + components/bookmarks/core/browser/bookmark_utils_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
6 years, 7 months ago (2014-05-10 01:43:42 UTC) #1
blundell
lgtm
6 years, 7 months ago (2014-05-12 06:51:56 UTC) #2
sky
LGTM
6 years, 7 months ago (2014-05-12 15:49:55 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-12 16:02:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/277093003/20001
6 years, 7 months ago (2014-05-12 16:02:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-12 16:03:45 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_tests_unit.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-12 16:03:46 UTC) #7
tfarina
6 years, 7 months ago (2014-05-12 16:52:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r269801 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698