Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: base/task_scheduler/task.cc

Issue 2770873003: Add CriticalClosure to BLOCK_SHUTDOWN Tasks (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/task.h" 5 #include "base/task_scheduler/task.h"
6 6
7 #include "base/critical_closure.h"
8
7 namespace base { 9 namespace base {
8 namespace internal { 10 namespace internal {
9 11
10 Task::Task(const tracked_objects::Location& posted_from, 12 Task::Task(const tracked_objects::Location& posted_from,
11 const Closure& task, 13 const Closure& task,
12 const TaskTraits& traits, 14 const TaskTraits& traits,
13 TimeDelta delay) 15 TimeDelta delay)
14 : PendingTask(posted_from, 16 : PendingTask(
15 task, 17 posted_from,
16 delay.is_zero() ? TimeTicks() : TimeTicks::Now() + delay, 18 traits.shutdown_behavior() == TaskShutdownBehavior::BLOCK_SHUTDOWN
17 false), // Not nestable. 19 ? MakeCriticalClosure(task)
20 : task,
21 delay.is_zero() ? TimeTicks() : TimeTicks::Now() + delay,
22 false), // Not nestable.
18 // Prevent a delayed BLOCK_SHUTDOWN task from blocking shutdown before 23 // Prevent a delayed BLOCK_SHUTDOWN task from blocking shutdown before
19 // being scheduled by changing its shutdown behavior to SKIP_ON_SHUTDOWN. 24 // being scheduled by changing its shutdown behavior to SKIP_ON_SHUTDOWN.
20 traits(!delay.is_zero() && 25 traits(!delay.is_zero() && traits.shutdown_behavior() ==
21 traits.shutdown_behavior() == 26 TaskShutdownBehavior::BLOCK_SHUTDOWN
22 TaskShutdownBehavior::BLOCK_SHUTDOWN
23 ? TaskTraits(traits).WithShutdownBehavior( 27 ? TaskTraits(traits).WithShutdownBehavior(
24 TaskShutdownBehavior::SKIP_ON_SHUTDOWN) 28 TaskShutdownBehavior::SKIP_ON_SHUTDOWN)
25 : traits), 29 : traits),
26 delay(delay) {} 30 delay(delay) {}
27 31
28 Task::~Task() = default; 32 Task::~Task() = default;
29 33
30 } // namespace internal 34 } // namespace internal
31 } // namespace base 35 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698