Remove ViewHostMsg_DidFirstPaintAfterLoad

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 3675 matching lines @@
   }
 
   if (proxy_routing_id_ != MSG_ROUTING_NONE) {
     // If this is a provisional frame associated with a proxy (i.e., a frame
     // created for a remote-to-local navigation), swap it into the frame tree
     // now.
     if (!SwapIn())
       return;
   }
 
-  // For navigations that change the document, the browser process needs to be
-  // notified of the first paint of that page, so it can cancel the timer that
-  // waits for it.
-  if (is_main_frame_ && !navigation_state->WasWithinSameDocument()) {
+  if (is_main_frame_ && !navigation_state->WasWithinSameDocument())

[Charlie Reis, 2017/03/24 16:52:01]

Let's leave some comment here so that it's clear why this is needed.  Something
like:

Navigations that change the document represent a new content source.  Keep track
of that on the widget to help the browser process detect when stale compositor
frames are being shown after a commit.

[Saman Sami, 2017/03/24 18:04:50]

That's a good comment. I'll add it verbatim.

     GetRenderWidget()->IncrementContentSourceId();
-    render_view_->QueueMessage(
-        new ViewHostMsg_DidFirstPaintAfterLoad(render_view_->routing_id_),
-        MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE);
-  }
 
   // When we perform a new navigation, we need to update the last committed
   // session history entry with state for the page we are leaving. Do this
   // before updating the current history item.
   SendUpdateState();
 
   // Update the current history item for this frame.
   current_history_item_ = item;
   // Note: don't reference |item| after this point, as its value may not match
   // |current_history_item_|.
@@ skipping 3251 matching lines @@
       policy(info.defaultPolicy),
       replaces_current_history_item(info.replacesCurrentHistoryItem),
       history_navigation_in_new_child_frame(
           info.isHistoryNavigationInNewChildFrame),
       client_redirect(info.isClientRedirect),
       cache_disabled(info.isCacheDisabled),
       form(info.form),
       source_location(info.sourceLocation) {}
 
 }  // namespace content