Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2770863002: Fix Windows native code profiling. (Closed)

Created:
3 years, 9 months ago by Florian Schneider
Modified:
3 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Windows native code profiling. The start address for native symbols is now correctly computed. Before it was left 0 - the symbol lookup code was just enabled in my previous CL. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/9111df606e5250e5bbfb241bbcf85fc4aea95802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/vm/native_symbol_win.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
3 years, 9 months ago (2017-03-22 21:16:02 UTC) #3
Cutch
lgtm
3 years, 9 months ago (2017-03-22 21:17:14 UTC) #4
Florian Schneider
3 years, 9 months ago (2017-03-22 21:17:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9111df606e5250e5bbfb241bbcf85fc4aea95802 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698