Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2770843002: Move GetCommandExecuteImplClsid into install_static. (Closed)

Created:
3 years, 9 months ago by grt (UTC plus 2)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GetCommandExecuteImplClsid into install_static. This is another step in bringing brand-specific constants together into one place, eventually leading to the demise of BrowserDistribution. BUG=373987 R=manzagop@chromium.org Review-Url: https://codereview.chromium.org/2770843002 Cr-Commit-Position: refs/heads/master@{#459383} Committed: https://chromium.googlesource.com/chromium/src/+/c19ddbffaccb399fa1dd6ca14a01ef89aef45848

Patch Set 1 #

Total comments: 2

Patch Set 2 : better cleanup #

Patch Set 3 : chromium compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -51 lines) Patch
M chrome/install_static/chromium_install_modes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/install_static/google_chrome_install_modes.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/install_static/install_constants.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/install_static/install_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/install_static/install_util.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 1 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/installer/setup/setup_util.cc View 1 4 chunks +33 lines, -0 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 2 6 chunks +16 lines, -0 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/browser_distribution.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution_dummy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 41 (23 generated)
grt (UTC plus 2)
PTAL
3 years, 9 months ago (2017-03-22 21:07:12 UTC) #2
manzagop (departed)
lgtm % question https://codereview.chromium.org/2770843002/diff/1/chrome/installer/setup/install_worker.cc File chrome/installer/setup/install_worker.cc (right): https://codereview.chromium.org/2770843002/diff/1/chrome/installer/setup/install_worker.cc#newcode278 chrome/installer/setup/install_worker.cc:278: DCHECK(!handler_class_uuid.empty()); Validating: - GetLegacyCommandExecuteImplClsid can return ...
3 years, 9 months ago (2017-03-22 21:51:30 UTC) #4
grt (UTC plus 2)
Thanks! +jwd for metrics OWNERS review https://codereview.chromium.org/2770843002/diff/1/chrome/installer/setup/install_worker.cc File chrome/installer/setup/install_worker.cc (right): https://codereview.chromium.org/2770843002/diff/1/chrome/installer/setup/install_worker.cc#newcode278 chrome/installer/setup/install_worker.cc:278: DCHECK(!handler_class_uuid.empty()); On 2017/03/22 ...
3 years, 9 months ago (2017-03-23 09:25:46 UTC) #9
jwd
lgtm
3 years, 9 months ago (2017-03-23 14:39:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770843002/40001
3 years, 9 months ago (2017-03-24 05:36:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/193559)
3 years, 9 months ago (2017-03-24 06:04:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770843002/60001
3 years, 9 months ago (2017-03-24 07:52:51 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/415871)
3 years, 9 months ago (2017-03-24 08:30:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770843002/60001
3 years, 9 months ago (2017-03-24 08:49:34 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/393809)
3 years, 9 months ago (2017-03-24 09:04:14 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770843002/60001
3 years, 9 months ago (2017-03-24 09:12:29 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/393826)
3 years, 9 months ago (2017-03-24 09:26:45 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770843002/60001
3 years, 9 months ago (2017-03-24 09:27:23 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/347312)
3 years, 9 months ago (2017-03-24 09:35:20 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770843002/60001
3 years, 9 months ago (2017-03-24 09:38:09 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/347356)
3 years, 9 months ago (2017-03-24 09:45:11 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770843002/60001
3 years, 9 months ago (2017-03-24 09:55:45 UTC) #38
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 10:43:38 UTC) #41
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c19ddbffaccb399fa1dd6ca14a01...

Powered by Google App Engine
This is Rietveld 408576698