Added browser and OS credits link to EULA page.

Added browser and OS credits link to EULA page for kiosk OOBE.

BUG=372098
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270269

[xiyuan, 2014-05-13 00:28:41]

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:510: if (true) {
Revert the debugging code?

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/resources...
File chrome/browser/resources/chromeos/login/oobe_screen_eula.js (right):

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_eula.js:17: });
nit: } should align with functioni, i.e. indent 2 more spaces

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_eula.js:21: });
ditto

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc (right):

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:50: "(function
HideElements() {\n"
nit: "\n" is not needed here and other places.

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:50: "(function
HideElements() {\n"
nit: HideElement -> hideElement.  Actually, we don't need function name here at
all.

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:52: "    var css =
rule,\n"
, -> ;

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:53: "    head =
document.head ||\n"
nit: var head = ...

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:55: "    style =
document.createElement('style');\n"
nit: var style = ...

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:65: " 
injectStyles('.homepage { display: none; }');\n"
Since we are modifying about_os_credits.html to add the name, why not put the
rules into the file and only trigger it here?

e.g.
In about_os_credits.html, add the following to css

.dialog #print-link { display: none; }
.dialog .homepage { display: none; }

then the JS here could be just add "dialog", e.g.
document.body.classList.toggle('dialog', true);

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:155: 
nit: keep only one empty line.

[zel, 2014-05-13 20:19:23]

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc (right):

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:50: "(function
HideElements() {\n"
On 2014/05/13 00:28:41, xiyuan wrote:
> nit: "\n" is not needed here and other places.

Done.

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:52: "    var css =
rule,\n"
On 2014/05/13 00:28:41, xiyuan wrote:
> , -> ;

Done.

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:53: "    head =
document.head ||\n"
On 2014/05/13 00:28:41, xiyuan wrote:
> nit: var head = ...

Done.

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:55: "    style =
document.createElement('style');\n"
On 2014/05/13 00:28:41, xiyuan wrote:
> nit: var style = ...

Done.

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:65: " 
injectStyles('.homepage { display: none; }');\n"
On 2014/05/13 00:28:41, xiyuan wrote:
> Since we are modifying about_os_credits.html to add the name, why not put the
> rules into the file and only trigger it here?
> 
> e.g.
> In about_os_credits.html, add the following to css
> 
> .dialog #print-link { display: none; }
> .dialog .homepage { display: none; }
> 
> then the JS here could be just add "dialog", e.g.
> document.body.classList.toggle('dialog', true);

Done.

https://codereview.chromium.org/277083004/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc:155: 
On 2014/05/13 00:28:41, xiyuan wrote:
> nit: keep only one empty line.

Done.

[xiyuan, 2014-05-13 20:45:53]

Do we need to worry about how user could close the credits dialog?

https://codereview.chromium.org/277083004/diff/90001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/277083004/diff/90001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:510: if (true) {
Debugging code still not removed.

https://codereview.chromium.org/277083004/diff/90001/chrome/browser/resources...
File chrome/browser/resources/chromeos/login/oobe_screen_eula.js (right):

https://codereview.chromium.org/277083004/diff/90001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_eula.js:117: });
nit: indent two more spaces to align with "function" in line 115.

https://codereview.chromium.org/277083004/diff/90001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_eula.js:121: });
ditto.

[zel, 2014-05-13 21:02:23]

https://codereview.chromium.org/277083004/diff/90001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/277083004/diff/90001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:510: if (true) {
On 2014/05/13 20:45:53, xiyuan wrote:
> Debugging code still not removed.

Done.

https://codereview.chromium.org/277083004/diff/90001/chrome/browser/resources...
File chrome/browser/resources/chromeos/login/oobe_screen_eula.js (right):

https://codereview.chromium.org/277083004/diff/90001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_eula.js:117: });
On 2014/05/13 20:45:53, xiyuan wrote:
> nit: indent two more spaces to align with "function" in line 115.

Done.

https://codereview.chromium.org/277083004/diff/90001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_eula.js:121: });
On 2014/05/13 20:45:53, xiyuan wrote:
> ditto.

Done.

[xiyuan, 2014-05-13 21:03:56]

lgtm

[zel, 2014-05-13 21:04:35]

The CQ bit was checked by zelidrag@chromium.org

[commit-bot: I haz the power, 2014-05-13 21:05:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zelidrag@chromium.org/277083004/100001

[commit-bot: I haz the power, 2014-05-14 00:36:43]

Change committed as 270269